From: hch <hch@lst.de>
To: Hans Holmberg <Hans.Holmberg@wdc.com>
Cc: Carlos Maiolino <cem@kernel.org>,
Dave Chinner <david@fromorbit.com>,
"Darrick J . Wong" <djwong@kernel.org>, hch <hch@lst.de>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] xfs: allow ro mounts if rtdev or logdev are read-only
Date: Wed, 30 Apr 2025 14:43:46 +0200 [thread overview]
Message-ID: <20250430124345.GA32269@lst.de> (raw)
In-Reply-To: <20250430083438.9426-1-hans.holmberg@wdc.com>
On Wed, Apr 30, 2025 at 08:35:34AM +0000, Hans Holmberg wrote:
> + blk_mode_t mode;
>
> - *bdev_filep = bdev_file_open_by_path(name,
> - BLK_OPEN_READ | BLK_OPEN_WRITE | BLK_OPEN_RESTRICT_WRITES,
> - mp->m_super, &fs_holder_ops);
> + mode = sb_open_mode(mp->m_super->s_flags);
> + *bdev_filep = bdev_file_open_by_path(name, mode,
> + mp->m_super, &fs_holder_ops);
We don't really need the local variable for mode now.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-04-30 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8exDmubwngY9v0_33lv5_EEDd8axqY8n_ZWu7-yEeEh_3YL_C0gcZAYXy-9vkbG2Kvwg0JtfuILWx0YfP1wTZw==@protonmail.internalid>
2025-04-30 8:35 ` [PATCH v2] xfs: allow ro mounts if rtdev or logdev are read-only Hans Holmberg
2025-04-30 9:36 ` Carlos Maiolino
2025-04-30 12:43 ` hch [this message]
2025-05-02 8:47 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250430124345.GA32269@lst.de \
--to=hch@lst.de \
--cc=Hans.Holmberg@wdc.com \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.