From: Kees Cook <kees@kernel.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Matt Roper" <matthew.d.roper@intel.com>,
"Gustavo Sousa" <gustavo.sousa@intel.com>,
"Andi Shyti" <andi.shyti@linux.intel.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Gnattu OC" <gnattuoc@me.com>,
"Nitin Gote" <nitin.r.gote@intel.com>,
"Ranu Maurya" <ranu.maurya@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Angus Chen" <angus.chen@intel.com>,
"Juha-Pekka Heikkila" <juhapekka.heikkila@gmail.com>,
"Yu Jiaoliang" <yujiaoliang@vivo.com>,
"Dnyaneshwar Bhadane" <dnyaneshwar.bhadane@intel.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] drm/i915/gt: Remove const from struct i915_wa list allocation
Date: Wed, 30 Apr 2025 13:56:51 -0700 [thread overview]
Message-ID: <202504301356.CB1EEC719@keescook> (raw)
In-Reply-To: <874iy8y0nz.fsf@intel.com>
On Mon, Apr 28, 2025 at 02:40:16PM +0300, Jani Nikula wrote:
> On Fri, 25 Apr 2025, Kees Cook <kees@kernel.org> wrote:
> > In preparation for making the kmalloc family of allocators type aware,
> > we need to make sure that the returned type from the allocation matches
> > the type of the variable being assigned. (Before, the allocator would
> > always return "void *", which can be implicitly cast to any pointer type.)
> >
> > The assigned type is "struct i915_wa *". The returned type, while
> > technically matching, will be const qualified. As there is no general
> > way to remove const qualifiers, adjust the allocation type to match
> > the assignment.
> >
> > Signed-off-by: Kees Cook <kees@kernel.org>
>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
>
> for merging via whichever tree you find best; please let us know if you
> want us to pick this up via drm-intel.
I was figuring each subsystem would want these individually, so please
take this via drm-intel. (Or I can take it if you'd rather not.)
Thanks!
-Kees
--
Kees Cook
next prev parent reply other threads:[~2025-04-30 20:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-26 6:13 [PATCH] drm/i915/gt: Remove const from struct i915_wa list allocation Kees Cook
2025-04-28 11:40 ` Jani Nikula
2025-04-30 20:56 ` Kees Cook [this message]
2025-05-07 13:05 ` Andi Shyti
2025-04-28 12:09 ` Tvrtko Ursulin
2025-04-30 20:56 ` Kees Cook
2025-04-28 13:45 ` ✓ i915.CI.BAT: success for " Patchwork
2025-04-28 13:46 ` Patchwork
2025-04-28 13:48 ` Patchwork
2025-04-28 13:50 ` Patchwork
2025-04-28 13:51 ` Patchwork
2025-04-28 13:51 ` Patchwork
2025-04-28 13:52 ` Patchwork
2025-04-28 15:17 ` ✓ i915.CI.Full: " Patchwork
2025-05-07 15:50 ` [PATCH] " Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202504301356.CB1EEC719@keescook \
--to=kees@kernel.org \
--cc=airlied@gmail.com \
--cc=andi.shyti@linux.intel.com \
--cc=angus.chen@intel.com \
--cc=dnyaneshwar.bhadane@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gnattuoc@me.com \
--cc=gustavo.sousa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=juhapekka.heikkila@gmail.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=nitin.r.gote@intel.com \
--cc=ranu.maurya@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
--cc=ville.syrjala@linux.intel.com \
--cc=yujiaoliang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.