From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Cosmin Tanislav <demonsingur@gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Romain Gantois <romain.gantois@bootlin.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Subject: Re: [PATCH v4 1/9] i2c: atr: Fix lockdep for nested ATRs
Date: Wed, 30 Apr 2025 16:31:57 +0200 [thread overview]
Message-ID: <20250430163157.15508066@booty> (raw)
In-Reply-To: <20250428102516.933571-2-demonsingur@gmail.com>
On Mon, 28 Apr 2025 13:25:06 +0300
Cosmin Tanislav <demonsingur@gmail.com> wrote:
> From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
>
> When we have an ATR, and another ATR as a subdevice of the first ATR,
> we get lockdep warnings for the i2c_atr.lock and
> i2c_atr_chan.orig_addrs_lock. This is because lockdep uses a static key
> for the locks, and doesn't see the locks of the separate ATR instances
> as separate.
>
> Fix this by generating a dynamic lock key per lock instance.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
I'm not very qualified about the lockdep side of the changes, but
regarding the ATR side this looks OK:
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-04-30 14:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 10:25 [PATCH v4 0/9] i2c: atr: allow usage of nested ATRs Cosmin Tanislav
2025-04-28 10:25 ` [PATCH v4 1/9] i2c: atr: Fix lockdep for " Cosmin Tanislav
2025-04-30 14:31 ` Luca Ceresoli [this message]
2025-04-28 10:25 ` [PATCH v4 2/9] i2c: atr: find_mapping() -> get_mapping() Cosmin Tanislav
2025-04-30 14:32 ` Luca Ceresoli
2025-04-28 10:25 ` [PATCH v4 3/9] i2c: atr: split up i2c_atr_get_mapping_by_addr() Cosmin Tanislav
2025-04-30 14:33 ` Luca Ceresoli
2025-05-05 10:26 ` Cosmin Tanislav
2025-05-05 11:22 ` Luca Ceresoli
2025-04-28 10:25 ` [PATCH v4 4/9] i2c: atr: do not create mapping in detach_addr() Cosmin Tanislav
2025-04-30 14:33 ` Luca Ceresoli
2025-04-28 10:25 ` [PATCH v4 5/9] i2c: atr: deduplicate logic in attach_addr() Cosmin Tanislav
2025-04-30 14:33 ` Luca Ceresoli
2025-05-05 15:40 ` Romain Gantois
2025-04-28 10:25 ` [PATCH v4 6/9] i2c: atr: allow replacing mappings " Cosmin Tanislav
2025-04-30 14:33 ` Luca Ceresoli
2025-05-05 10:33 ` Cosmin Tanislav
2025-05-05 11:32 ` Luca Ceresoli
2025-04-28 10:25 ` [PATCH v4 7/9] i2c: atr: add flags parameter to i2c_atr_new() Cosmin Tanislav
2025-04-30 14:34 ` Luca Ceresoli
2025-05-05 15:50 ` Romain Gantois
2025-04-28 10:25 ` [PATCH v4 8/9] i2c: atr: add static flag Cosmin Tanislav
2025-04-30 14:36 ` Luca Ceresoli
2025-05-05 15:58 ` Romain Gantois
2025-04-28 10:25 ` [PATCH v4 9/9] i2c: atr: add passthrough flag Cosmin Tanislav
2025-04-30 14:36 ` Luca Ceresoli
2025-05-05 16:13 ` Romain Gantois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250430163157.15508066@booty \
--to=luca.ceresoli@bootlin.com \
--cc=arnd@arndb.de \
--cc=demonsingur@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=romain.gantois@bootlin.com \
--cc=tomi.valkeinen+renesas@ideasonboard.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.