All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herve Codina <herve.codina@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ayush Singh <ayush@beagleboard.org>,
	xypron.glpk@gmx.de, Jason Kridner <jkridner@beagleboard.org>,
	Deepak Khatri <lorforlinux@beagleboard.org>,
	Dhruva Gole <d-gole@ti.com>,
	Robert Nelson <robertcnelson@beagleboard.org>,
	Andrew Davis <afd@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	David Gibson <david@gibson.dropbear.id.au>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Pantelis Antoniou <pantelis.antoniou@gmail.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [Discussion] Global vs Local devicetree overlays for addon board + connector setups
Date: Wed, 30 Apr 2025 16:58:23 +0200	[thread overview]
Message-ID: <20250430165823.076e645b@bootlin.com> (raw)
In-Reply-To: <CAMuHMdXoNk3cFm10dJNMK19Ym2RWZ_hyRpDXRZ_gjPAPZpAuVQ@mail.gmail.com>

Hi Geert,

On Wed, 30 Apr 2025 16:31:17 +0200
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Hi Hervé,
> 
> On Wed, 30 Apr 2025 at 16:09, Herve Codina <herve.codina@bootlin.com> wrote:
> > On Wed, 30 Apr 2025 17:37:33 +0530
> > Ayush Singh <ayush@beagleboard.org> wrote:
> >
> > ...
> >  
> > > 1. __symbols__ based approach [3]
> > >
> > >
> > > This was originally proposed by Andre Davis [3]. It defines an overlay
> > > with just special names in `__symbols__`, which is used along with an
> > > overlay for the addon-board, which makes use of the node names defined
> > > in the connector `__symbols__` overlay. Please take a look at the
> > > original patch series since it provides a working example of how it can
> > > be used [3].
> > >  
> >
> > The __symbols__ based approach needs 2 overlays to handle the case where
> > 2 connectors (A and B) are present an you want to connect a board described
> > by a single overlay.
> >
> > The first overlay applied "adapts" the __symbols__ node for the connector
> > where the board is connected (for instance connector A) in order to have
> > the symbols used by the overlay describing the board resolved to the
> > correct symbols.
> >
> > I think this open race conditions when the overlay is applied by the kernel
> > itself. Indeed, we need to perform 2 steps in an atomic way:
> >   1) Adapt symbols
> >   2) Applied board overlay  
> 
> I think that can be solved by not applying them in two steps, but by
> in-memory merging of the symbol and board overlays first, and applying
> the result.

Yes, indeed.

This implies a significant work for the __symbols__ based approach. I think
we can say that "it works pretty well with existing infrastructure" is no
more fully true.

Best regards,
Hervé

  reply	other threads:[~2025-04-30 14:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30 12:07 [Discussion] Global vs Local devicetree overlays for addon board + connector setups Ayush Singh
2025-04-30 14:09 ` Herve Codina
2025-04-30 14:31   ` Geert Uytterhoeven
2025-04-30 14:58     ` Herve Codina [this message]
2025-05-01  6:05   ` Ayush Singh
2025-05-04 12:33   ` Ayush Singh
2025-05-04 12:50     ` Greg Kroah-Hartman
2025-05-04 13:00       ` Ayush Singh
2025-05-04 13:13         ` Greg Kroah-Hartman
2025-05-05  6:43           ` Geert Uytterhoeven
2025-05-05 20:56             ` Rob Herring
2025-06-04 19:03 ` Andrew Davis
2025-06-05  7:22   ` Ayush Singh
2025-06-09 14:13     ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250430165823.076e645b@bootlin.com \
    --to=herve.codina@bootlin.com \
    --cc=afd@ti.com \
    --cc=ayush@beagleboard.org \
    --cc=d-gole@ti.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jkridner@beagleboard.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorforlinux@beagleboard.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=pantelis.antoniou@gmail.com \
    --cc=robertcnelson@beagleboard.org \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.