From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Peter Chen <peter.chen@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
kernel@pengutronix.de, Fabio Estevam <festevam@gmail.com>,
Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
imx@lists.linux.dev, stable@kernel.org
Subject: Re: [PATCH] usb: chipidea: ci_hdrc_imx: Fix NPD of usbmisc_data
Date: Thu, 1 May 2025 17:38:14 +0200 [thread overview]
Message-ID: <2025050100-getting-curler-88aa@gregkh> (raw)
In-Reply-To: <20250422185601.80199-1-wahrenst@gmx.net>
On Tue, Apr 22, 2025 at 08:56:01PM +0200, Stefan Wahren wrote:
> The commit 74adad500346 ("usb: chipidea: ci_hdrc_imx: decrement device's
> refcount in .remove() and in the error path of .probe()") introduced
> a NULL pointer dereference on platforms which have no usbmisc_data
> (e.g. i.MX28). So add the missing checks in .probe() and .remove().
>
> Fixes: 74adad500346 ("usb: chipidea: ci_hdrc_imx: decrement device's refcount in .remove() and in the error path of .probe()")
> Cc: <stable@kernel.org>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> ---
> drivers/usb/chipidea/ci_hdrc_imx.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Does not apply to 6.15-rc4 at all, can you rebase and resubmit?
thanks,
greg k-h
next prev parent reply other threads:[~2025-05-01 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 18:56 [PATCH] usb: chipidea: ci_hdrc_imx: Fix NPD of usbmisc_data Stefan Wahren
2025-05-01 15:38 ` Greg Kroah-Hartman [this message]
2025-05-02 8:35 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025050100-getting-curler-88aa@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=joe@pf.is.s.u-tokyo.ac.jp \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.