From: Dave Airlie <airlied@gmail.com>
To: dri-devel@lists.freedesktop.org, tj@kernel.org,
christian.koenig@amd.com, Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>
Cc: cgroups@vger.kernel.org, Waiman Long <longman@redhat.com>,
simona@ffwll.ch
Subject: [PATCH 2/5] memcg: add hooks for gpu memcg charging/uncharging.
Date: Fri, 2 May 2025 13:36:01 +1000 [thread overview]
Message-ID: <20250502034046.1625896-3-airlied@gmail.com> (raw)
In-Reply-To: <20250502034046.1625896-1-airlied@gmail.com>
From: Dave Airlie <airlied@redhat.com>
As per the socket hooks, just adds two APIs to charge GPU pages
to the memcg and uncharge them.
Suggested by Waiman.
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
include/linux/memcontrol.h | 5 +++++
mm/memcontrol.c | 34 ++++++++++++++++++++++++++++++++++
2 files changed, 39 insertions(+)
diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index 4058d4bd94ed..f74b7db89f00 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -1618,6 +1618,11 @@ struct sock;
bool mem_cgroup_charge_skmem(struct mem_cgroup *memcg, unsigned int nr_pages,
gfp_t gfp_mask);
void mem_cgroup_uncharge_skmem(struct mem_cgroup *memcg, unsigned int nr_pages);
+
+bool mem_cgroup_charge_gpu(struct mem_cgroup *memcg, unsigned int nr_pages,
+ gfp_t gfp_mask);
+void mem_cgroup_uncharge_gpu(struct mem_cgroup *memcg, unsigned int nr_pages);
+
#ifdef CONFIG_MEMCG
extern struct static_key_false memcg_sockets_enabled_key;
#define mem_cgroup_sockets_enabled static_branch_unlikely(&memcg_sockets_enabled_key)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 25471a0fd0be..76a0ec34b7dc 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4958,6 +4958,40 @@ void mem_cgroup_uncharge_skmem(struct mem_cgroup *memcg, unsigned int nr_pages)
refill_stock(memcg, nr_pages);
}
+/**
+ * mem_cgroup_charge_gpu - charge GPU memory
+ * @memcg: memcg to charge
+ * @nr_pages: number of pages to charge
+ * @gfp_mask: reclaim mode
+ *
+ * Charges @nr_pages to @memcg. Returns %true if the charge fit within
+ * @memcg's configured limit, %false if it doesn't.
+ */
+bool mem_cgroup_charge_gpu(struct mem_cgroup *memcg, unsigned int nr_pages,
+ gfp_t gfp_mask)
+{
+ if (try_charge_memcg(memcg, gfp_mask, nr_pages) == 0) {
+ mod_memcg_state(memcg, MEMCG_GPU, nr_pages);
+ return true;
+ }
+
+ return false;
+}
+EXPORT_SYMBOL_GPL(mem_cgroup_charge_gpu);
+
+/**
+ * mem_cgroup_uncharge_gpu - uncharge GPU memory
+ * @memcg: memcg to uncharge
+ * @nr_pages: number of pages to uncharge
+ */
+void mem_cgroup_uncharge_gpu(struct mem_cgroup *memcg, unsigned int nr_pages)
+{
+ mod_memcg_state(memcg, MEMCG_GPU, -nr_pages);
+
+ refill_stock(memcg, nr_pages);
+}
+EXPORT_SYMBOL_GPL(mem_cgroup_uncharge_gpu);
+
static int __init cgroup_memory(char *s)
{
char *token;
--
2.49.0
next prev parent reply other threads:[~2025-05-02 3:42 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 3:35 [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2) Dave Airlie
2025-05-02 3:36 ` [PATCH 1/5] memcg: add GPU statistic Dave Airlie
2025-05-02 3:36 ` Dave Airlie [this message]
2025-05-02 3:36 ` [PATCH 3/5] ttm: add initial memcg integration. (v2) Dave Airlie
2025-05-02 12:01 ` Christian König
2025-05-02 14:24 ` kernel test robot
2025-05-03 2:09 ` kernel test robot
2025-05-02 3:36 ` [PATCH 4/5] amdgpu: add support for memcg integration Dave Airlie
2025-05-02 14:01 ` Waiman Long
2025-05-02 3:36 ` [PATCH 5/5] nouveau: add " Dave Airlie
2025-05-06 0:37 ` [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2) Shakeel Butt
2025-05-06 0:59 ` Dave Airlie
2025-05-07 17:52 ` Johannes Weiner
2025-05-07 22:03 ` Dave Airlie
2025-05-07 22:11 ` Dave Airlie
2025-05-13 7:54 ` Johannes Weiner
2025-05-15 3:02 ` Dave Airlie
2025-05-15 8:55 ` Christian König
2025-05-15 15:04 ` Waiman Long
2025-05-15 15:16 ` Christian König
2025-05-15 16:08 ` Johannes Weiner
2025-05-16 6:53 ` Christian König
2025-05-16 14:53 ` Johannes Weiner
2025-05-16 15:35 ` Christian König
2025-05-16 16:41 ` Johannes Weiner
2025-05-16 17:42 ` Christian König
2025-05-16 20:04 ` Johannes Weiner
2025-05-16 20:25 ` Dave Airlie
2025-05-18 16:28 ` Christian König
2025-05-19 6:18 ` Dave Airlie
2025-05-19 8:26 ` Christian König
2025-05-22 19:51 ` Tejun Heo
2025-05-23 7:58 ` Christian König
2025-05-23 17:06 ` Tejun Heo
2025-05-26 8:19 ` Christian König
2025-05-26 20:13 ` Dave Airlie
2025-05-27 8:01 ` Christian König
2025-05-16 16:12 ` Johannes Weiner
2025-05-21 2:23 ` Dave Airlie
2025-05-21 7:50 ` Christian König
2025-05-21 14:43 ` Johannes Weiner
2025-05-22 7:03 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250502034046.1625896-3-airlied@gmail.com \
--to=airlied@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hannes@cmpxchg.org \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=simona@ffwll.ch \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.