From: Al Viro <viro@zeniv.linux.org.uk>
To: Matthew Brost <matthew.brost@intel.com>
Cc: "Kees Cook" <kees@kernel.org>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Christian Koenig" <christian.koenig@amd.com>,
"Somalapuram Amaranath" <Amaranath.Somalapuram@amd.com>,
"Huang Rui" <ray.huang@amd.com>,
"Matthew Auld" <matthew.auld@intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>
Subject: Re: [PATCH v2] drm/ttm: Silence randstruct warning about casting struct file
Date: Fri, 2 May 2025 05:31:49 +0100 [thread overview]
Message-ID: <20250502043149.GW2023217@ZenIV> (raw)
In-Reply-To: <aBRJcXfBuK29mVP+@lstrano-desk.jf.intel.com>
On Thu, May 01, 2025 at 09:26:25PM -0700, Matthew Brost wrote:
> I;m fairly certain is just aliasing... but I do understand a file cannot
> be embedded. Would comment help here indicating no other fields should
> be added to ttm_backup without struct file be converted to pointer or
> that just to risky?
What exactly are you trying to do there? IOW, is that always supposed to
be a struct file, or something dependent upon something in struct ttm_tt
instance, or...?
And what is the lifecycle of that thing? E.g. what is guaranteed about
ttm_backup_fini() vs. functions accessing the damn thing? Are they
serialized on something/tied to lifecycle stages of struct ttm_tt?
next prev parent reply other threads:[~2025-05-02 4:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 0:24 [PATCH v2] drm/ttm: Silence randstruct warning about casting struct file Kees Cook
2025-05-02 2:13 ` Matthew Brost
2025-05-02 2:24 ` Kees Cook
2025-05-02 2:34 ` Al Viro
2025-05-02 2:46 ` Kees Cook
2025-05-02 4:26 ` Matthew Brost
2025-05-02 4:31 ` Al Viro [this message]
2025-05-02 4:52 ` Matthew Brost
2025-05-02 5:33 ` Al Viro
2025-05-02 7:49 ` Christian König
2025-05-02 10:44 ` Thomas Hellström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250502043149.GW2023217@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=Amaranath.Somalapuram@amd.com \
--cc=airlied@gmail.com \
--cc=brauner@kernel.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jack@suse.cz \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
--cc=mripard@kernel.org \
--cc=ray.huang@amd.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.