All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-input@vger.kernel.org,
	"Nuno Sá" <nuno.sa@analog.com>, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Uwe Kleine-König" <ukleinek@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Liu Ying" <victor.liu@nxp.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v2 00/17] mfd: adp5585: support keymap events and drop legacy Input driver
Date: Fri, 2 May 2025 09:30:55 +0100	[thread overview]
Message-ID: <20250502083055.GG3865826@google.com> (raw)
In-Reply-To: <d78a923a7da54292f98746c71ff84160a5c42963.camel@gmail.com>

On Fri, 02 May 2025, Nuno Sá wrote:

> On Fri, 2025-05-02 at 08:13 +0100, Lee Jones wrote:
> > On Thu, 01 May 2025, Laurent Pinchart wrote:
> > 
> > > Hi Lee,
> > > 
> > > On Thu, May 01, 2025 at 01:00:03PM +0100, Lee Jones wrote:
> > > > On Tue, 15 Apr 2025 15:49:16 +0100, Nuno Sá wrote:
> > > > > The adp5585 MFD driver was introduced in 6.11 adding support for gpio
> > > > > and PWM. However, the gpio part of it was already supported as part of
> > > > > the keyboard driver:
> > > > > 
> > > > > https://elixir.bootlin.com/linux/v6.14-rc6/source/drivers/input/keyboard/adp5589-keys.c#L532
> > > > > 
> > > > > On top of that it also overlapped with my refactoring of the above
> > > > > driver [1]
> > > > > to drop usage of platform data and use FW properties instead.
> > > > > 
> > > > > [...]
> > > > 
> > > > Applied, thanks!
> > > > 
> > > > [01/17] dt-bindings: mfd: adp5585: ease on the required properties
> > > >         commit: 3a2ea3e9f369bdae939bcccff67a77a6281dca74
> > > > [02/17] mfd: adp5585: enable oscilator during probe
> > > >         commit: 7353f196fd73b79e30ff750d93caf096ed660e1b
> > > > [03/17] pwm: adp5585: don't control OSC_EN in the pwm driver
> > > >         commit: 7c7e9f08a1a9bf16b6c1942c2e0cb919da855970
> > > > [04/17] mfd: adp5585: make use of MFD_CELL_NAME()
> > > >         commit: e72e9148d017535b39500d0aad624d0a0fcd2ce7
> > > > [05/17] dt-bindings: mfd: adp5585: document adp5589 I/O expander
> > > >         commit: 6da01b9d833c5efbce7c2e30dde276e0d29105f8
> > > > [06/17] mfd: adp5585: add support for adp5589
> > > >         commit: 382dc0327b8a9ee03c901df9b85134c68917becc
> > > > [07/17] gpio: adp5585: add support for the ad5589 expander
> > > >         commit: cff3cef09595001140bd29aedf33fc84998bf77c
> > > > [08/17] pwm: adp5585: add support for adp5589
> > > >         commit: 333b66fd3edfe18db4dc16041328a89144b73067
> > > > [09/17] dt-bindings: mfd: adp5585: add properties for input events
> > > >         commit: 7bdb41d7a85e1c6244da57d4dcc491df962ff3fb
> > > > [10/17] mfd: adp5585: add support for key events
> > > >         commit: 8814ac45c75fcce55896bc376a97b56f392925c3
> > > > [11/17] gpio: adp5585: support gpi events
> > > >         commit: 8f3d9b44c5c5ada312d0ef71ec0181011854a95b
> > > > [12/17] Input: adp5585: Add Analog Devices ADP5585/89 support
> > > >         commit: a53fc67a1e21a8507821263946b1d65687b0284f
> > > > [13/17] Input: adp5589: remove the driver
> > > >         commit: 216c99cf1002a42f896b54fab09823e8ba46b218
> > > > [14/17] mfd: adp5585: support getting vdd regulator
> > > >         commit: 63a8717f744d51ea0c8228e09db4233d48f2f9ba
> > > > [15/17] dt-bindings: mfd: adp5585: document reset gpio
> > > >         commit: 49c887f0547bc14eb50ba20e1c8acb7255af3b86
> > > > [16/17] mfd: adp5585: add support for a reset pin
> > > >         commit: 01c328823459456fb99469cc37f270f70d41fd2a
> > > > [17/17] pwm: adp5585: make sure to include mod_devicetable.h
> > > >         (no commit info)
> > > 
> > > I'm a bit surprised, didn't you ask for changes, calling for a v3 ?
> > 
> > Yes, sorry.  My fault.  Tooling error.  Please disregard.
> 
> I was wondering the same...

Found out what happened.

I applied them all to grep for the spelling issue reported by Colin.
However, I hit return (sending the thank-yous) instead of Ctrl+c (to
cancel them).

Apologies for the confusion.

-- 
Lee Jones [李琼斯]

      reply	other threads:[~2025-05-02  8:31 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15 14:49 [PATCH v2 00/17] mfd: adp5585: support keymap events and drop legacy Input driver Nuno Sá
2025-04-15 14:49 ` Nuno Sá via B4 Relay
2025-04-15 14:49 ` [PATCH v2 01/17] dt-bindings: mfd: adp5585: ease on the required properties Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-21  8:56   ` Laurent Pinchart
2025-04-21 12:12     ` Nuno Sá
2025-04-21 12:29       ` Laurent Pinchart
2025-04-21 12:45         ` Nuno Sá
2025-04-21 18:57   ` Rob Herring (Arm)
2025-04-15 14:49 ` [PATCH v2 02/17] mfd: adp5585: enable oscilator during probe Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-21  8:57   ` Laurent Pinchart
2025-04-21 12:14     ` Nuno Sá
2025-04-21 22:03       ` Laurent Pinchart
2025-04-22  7:50         ` Nuno Sá
2025-04-15 14:49 ` [PATCH v2 03/17] pwm: adp5585: don't control OSC_EN in the pwm driver Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-15 14:49 ` [PATCH v2 04/17] mfd: adp5585: make use of MFD_CELL_NAME() Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-21  9:03   ` Laurent Pinchart
2025-04-24 15:55   ` Lee Jones
2025-04-15 14:49 ` [PATCH v2 05/17] dt-bindings: mfd: adp5585: document adp5589 I/O expander Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-21  9:07   ` Laurent Pinchart
2025-04-21 18:59   ` Rob Herring (Arm)
2025-04-15 14:49 ` [PATCH v2 06/17] mfd: adp5585: add support for adp5589 Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-21  9:15   ` Laurent Pinchart
2025-04-21 12:21     ` Nuno Sá
2025-04-21 22:06       ` Laurent Pinchart
2025-04-22  7:51         ` Nuno Sá
2025-04-24 16:01         ` Lee Jones
2025-04-24 16:18   ` Lee Jones
2025-04-24 16:30     ` Laurent Pinchart
2025-04-24 16:38       ` Lee Jones
2025-04-24 19:39         ` Laurent Pinchart
2025-04-25  7:58           ` Lee Jones
2025-04-25  9:13             ` Laurent Pinchart
2025-04-25  9:23               ` Lee Jones
2025-04-28  9:24               ` Nuno Sá
2025-04-15 14:49 ` [PATCH v2 07/17] gpio: adp5585: add support for the ad5589 expander Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-17 12:27   ` Bartosz Golaszewski
2025-04-21  9:23   ` Laurent Pinchart
2025-04-21 12:22     ` Nuno Sá
2025-04-15 14:49 ` [PATCH v2 08/17] pwm: adp5585: add support for adp5589 Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-15 14:49 ` [PATCH v2 09/17] dt-bindings: mfd: adp5585: add properties for input events Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-21  9:28   ` Laurent Pinchart
2025-04-21 12:24     ` Nuno Sá
2025-04-29 15:03   ` Rob Herring (Arm)
2025-04-15 14:49 ` [PATCH v2 10/17] mfd: adp5585: add support for key events Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-21  9:33   ` Laurent Pinchart
2025-04-21 12:32     ` Nuno Sá
2025-04-21 22:13       ` Laurent Pinchart
2025-04-24 16:07     ` Lee Jones
2025-04-24 16:24       ` Laurent Pinchart
2025-04-24 16:28         ` Lee Jones
2025-04-15 14:49 ` [PATCH v2 11/17] gpio: adp5585: support gpi events Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-17 12:28   ` Bartosz Golaszewski
2025-04-15 14:49 ` [PATCH v2 12/17] Input: adp5585: Add Analog Devices ADP5585/89 support Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-19  2:44   ` Dmitry Torokhov
2025-04-21  9:35   ` Laurent Pinchart
2025-04-21 12:33     ` Nuno Sá
2025-04-15 14:49 ` [PATCH v2 13/17] Input: adp5589: remove the driver Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-19  2:45   ` Dmitry Torokhov
2025-04-21  9:40   ` Laurent Pinchart
2025-04-21 12:34     ` Nuno Sá
2025-04-15 14:49 ` [PATCH v2 14/17] mfd: adp5585: support getting vdd regulator Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-21  9:48   ` Laurent Pinchart
2025-04-21 12:38     ` Nuno Sá
2025-04-21 22:09       ` Laurent Pinchart
2025-04-22  8:12         ` Nuno Sá
2025-04-15 14:49 ` [PATCH v2 15/17] dt-bindings: mfd: adp5585: document reset gpio Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-21  9:36   ` Laurent Pinchart
2025-04-15 14:49 ` [PATCH v2 16/17] mfd: adp5585: add support for a reset pin Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-21  9:46   ` Laurent Pinchart
2025-04-21 12:42     ` Nuno Sá
2025-04-21 22:10       ` Laurent Pinchart
2025-04-15 14:49 ` [PATCH v2 17/17] pwm: adp5585: make sure to include mod_devicetable.h Nuno Sá
2025-04-15 14:49   ` Nuno Sá via B4 Relay
2025-04-21  9:50   ` Laurent Pinchart
2025-04-15 15:56 ` [PATCH v2 00/17] mfd: adp5585: support keymap events and drop legacy Input driver Laurent Pinchart
2025-04-21 10:08   ` Laurent Pinchart
2025-04-16  9:02 ` Liu Ying
2025-04-16 10:03   ` Nuno Sá
2025-05-01 12:00 ` Lee Jones
2025-05-01 14:09   ` Laurent Pinchart
2025-05-02  7:13     ` Lee Jones
2025-05-02  7:35       ` Nuno Sá
2025-05-02  8:30         ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250502083055.GG3865826@google.com \
    --to=lee@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=noname.nuno@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=ukleinek@kernel.org \
    --cc=victor.liu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.