From: "Nysal Jan K.A." <nysal@linux.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Cc: luogengkun@huaweicloud.com, dianders@chromium.org,
joel.granados@kernel.org, song@kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org,
"Nysal Jan K.A." <nysal@linux.ibm.com>
Subject: [PATCH] watchdog: Fix the SOFTLOCKUP_DETECTOR=n case
Date: Fri, 2 May 2025 16:41:20 +0530 [thread overview]
Message-ID: <20250502111120.282690-1-nysal@linux.ibm.com> (raw)
In-Reply-To: <20250430205503.4a316f48@canb.auug.org.au>
Update watchdog_thresh when SOFTLOCKUP_DETECTOR=n.
Additionally fix a build failure in this case as well.
Fixes: 0bff3dababb07 ("watchdog: fix watchdog may detect false positive of softlockup")
Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Closes: https://lore.kernel.org/all/339e2b3e-c7ee-418f-a84c-9c6360dc570b@linux.ibm.com
Signed-off-by: Nysal Jan K.A. <nysal@linux.ibm.com>
---
The "Fixes:" SHA1 points to the commit in mm-nonmm-unstable and will need updating
kernel/watchdog.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 80d1a1dae27..2d283e92be5 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -923,10 +923,12 @@ static __init void lockup_detector_setup(void)
}
#else /* CONFIG_SOFTLOCKUP_DETECTOR */
-static void __lockup_detector_reconfigure(void)
+static void __lockup_detector_reconfigure(bool thresh_changed)
{
cpus_read_lock();
watchdog_hardlockup_stop();
+ if (thresh_changed)
+ watchdog_thresh = READ_ONCE(watchdog_thresh_next);
lockup_detector_update_enable();
watchdog_hardlockup_start();
cpus_read_unlock();
--
2.47.0
next prev parent reply other threads:[~2025-05-02 11:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-26 15:09 [linux-next]Build Failure: kernel/watchdog.c:936:2: error: too many arguments Venkat Rao Bagalkote
2025-04-27 22:41 ` Stephen Rothwell
2025-04-28 6:13 ` Venkat Rao Bagalkote
2025-04-28 9:41 ` Venkat Rao Bagalkote
2025-04-30 6:27 ` Venkat Rao Bagalkote
2025-04-30 10:55 ` Stephen Rothwell
2025-05-02 11:11 ` Nysal Jan K.A. [this message]
2025-05-02 12:00 ` [PATCH] watchdog: Fix the SOFTLOCKUP_DETECTOR=n case Venkat Rao Bagalkote
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250502111120.282690-1-nysal@linux.ibm.com \
--to=nysal@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dianders@chromium.org \
--cc=joel.granados@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luogengkun@huaweicloud.com \
--cc=maddy@linux.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=venkat88@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.