From: Trevor Woerner <twoerner@gmail.com>
To: docs@lists.yoctoproject.org
Subject: [PATCH v2] contributor-guide/submit-changes: encourage patch version changelogs
Date: Fri, 2 May 2025 13:21:43 -0400 [thread overview]
Message-ID: <20250502172143.31713-1-twoerner@gmail.com> (raw)
Add a section after the 'git format-patch' information encouraging developers
to add patch version changelogs to their patch updates.
Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
changes in v2:
- clarify SoB line
- clarify "this patch was added in v2" line
---
.../contributor-guide/submit-changes.rst | 32 +++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/documentation/contributor-guide/submit-changes.rst b/documentation/contributor-guide/submit-changes.rst
index 0675aac984cf..6d5d69d7cfb4 100644
--- a/documentation/contributor-guide/submit-changes.rst
+++ b/documentation/contributor-guide/submit-changes.rst
@@ -776,6 +776,38 @@ argument to ``git format-patch`` with a version number::
git format-patch -v2 <ref-branch>
+
+After generating updated patches (v2, v3, and so on) via ``git
+format-patch``, ideally developers will add a patch version changelog
+to each patch that describes what has changed between each revision of
+the patch. Add patch version changelogs after the ``---`` marker in the
+patch, indicating that this information is part of this patch, but is not
+suitable for inclusion in the commit message (i.e. the git history) itself.
+Providing a patch version changelog makes it easier for maintainers and
+reviewers to succinctly understand what changed in all versions of the
+patch, without having to consult alternate sources of information, such as
+searching through messages on a mailing list. For example::
+
+ <patch title>
+
+ <commit message>
+
+ <Signed-off-by/other trailers>
+ ---
+ changes in v4:
+ - provide a clearer commit message
+ - fix spelling mistakes
+
+ changes in v3:
+ - replace func() to use other_func() instead
+
+ changes in v2:
+ - this patch was added in v2
+ ---
+ <diffstat output>
+
+ <unified diff>
+
Lastly please ensure that you also test your revised changes. In particular
please don't just edit the patch file written out by ``git format-patch`` and
resend it.
--
2.44.0.501.g19981daefd7c
next reply other threads:[~2025-05-02 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 17:21 Trevor Woerner [this message]
2025-05-05 9:15 ` [docs] [PATCH v2] contributor-guide/submit-changes: encourage patch version changelogs Quentin Schulz
2025-05-21 16:42 ` Antonin Godard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250502172143.31713-1-twoerner@gmail.com \
--to=twoerner@gmail.com \
--cc=docs@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.