From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: Samiullah Khawaja <skhawaja@google.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
almasrymina@google.com, willemb@google.com,
mkarsten@uwaterloo.ca, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v6] Add support to set napi threaded for individual napi
Date: Fri, 2 May 2025 19:15:48 -0700 [thread overview]
Message-ID: <20250502191548.559cc416@kernel.org> (raw)
In-Reply-To: <aBJntw1WwxxFJ9e2@LQ3V64L9R2>
On Wed, 30 Apr 2025 11:11:03 -0700 Joe Damato wrote:
> > We should check the discussions we had when threaded NAPI was added.
> > I feel nothing was exposed in terms of observability so leaving the
> > thread running didn't seem all that bad back then. Stopping the NAPI
> > polling safely is not entirely trivial, we'd need to somehow grab
> > the SCHED bit like busy polling does, and then re-schedule.
> > Or have the thread figure out that it's done and exit.
>
> Actually, we ended up adding the explicit ownership bits so it may not
> be all that hard any more.. Worth trying.
>
> So based on all of the messages in the v5 and in the past, it seems pretty
> clear to me that this needs to be fixed.
Joe is right, sorry for not replying earlier.
Let's try to stop / start the thread on SET immediately.
IIRC there was also a suggestion to defer start / stop to
napi_enable() if NAPI is not enabled -- that's not needed.
prev parent reply other threads:[~2025-05-03 2:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 22:26 [PATCH net-next v6] Add support to set napi threaded for individual napi Samiullah Khawaja
2025-04-29 23:57 ` Joe Damato
2025-04-30 1:16 ` Samiullah Khawaja
2025-04-30 16:53 ` Joe Damato
2025-04-30 17:54 ` Samiullah Khawaja
2025-04-30 18:11 ` Joe Damato
2025-05-03 2:15 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250502191548.559cc416@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=mkarsten@uwaterloo.ca \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=skhawaja@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.