All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Catherine Hoang <catherine.hoang@oracle.com>,
	linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH v5] generic: add a test for atomic writes
Date: Fri, 2 May 2025 12:39:42 -0700	[thread overview]
Message-ID: <20250502193942.GP25675@frogsfrogsfrogs> (raw)
In-Reply-To: <aBRwTFxik14x-hyX@infradead.org>

On Fri, May 02, 2025 at 12:12:12AM -0700, Christoph Hellwig wrote:
> This fails in my zoned device tests with;
> 
> mkfs.xfs: error - cannot set blocksize 512 on block device /dev/nvme3n1: Invalid argument
> 
> that error turns to be because the scratch rtdev /dev/nvme3n1 has a 4k
> LBA size, while the main scratch device has a 512 byte sector size,
> which is a configuration common for but not exclusive to zoned device,
> and which means that we can't use a 512 byte block size for the file
> system.
> 
> I'm not really sure how to best add the case of a larger LBA size on
> the rt device to this test, though.

Me neither.  We can't write 512b blocks to the rt device obviously, but
I think the whole point of the separate "sector" size is that's the
maximum size that the fs knows it can write to the device without
tearing.

Maybe there's a way out of this: the only metadata on the realtime
volume is the rt superblock, whose size is a full fsblock.  Perhaps we
could set/validate the block size of the rt dev with the fsblock size
instead?

--D

  reply	other threads:[~2025-05-02 19:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10  4:23 [PATCH v5] generic: add a test for atomic writes Catherine Hoang
2025-04-15 12:59 ` Ritesh Harjani
2025-04-15 18:44   ` Darrick J. Wong
2025-04-17 20:32     ` Darrick J. Wong
2025-05-02  7:12 ` Christoph Hellwig
2025-05-02 19:39   ` Darrick J. Wong [this message]
2025-05-05  5:37     ` Christoph Hellwig
2025-05-05 14:57       ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250502193942.GP25675@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=catherine.hoang@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.