All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "zhilin.yang" <zlyang_001@163.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: u_ether: Continue to send skbs if remote wakeup fails
Date: Sat, 3 May 2025 14:30:19 +0200	[thread overview]
Message-ID: <2025050321-apprehend-lavish-ea92@gregkh> (raw)
In-Reply-To: <20250502145352.557174-1-zlyang_001@163.com>

On Fri, May 02, 2025 at 10:53:52PM +0800, zhilin.yang wrote:
> While UDC suspends, u_ether attempts to remote wakeup
> the host if there are any pending transfers. If there are no
> pending transfers, the is_suspend flag is set. If the is_suspend
> flag is set, it attempts to remote wakeup the host when start to
> send skbs. However, if host does not support remote wakeup, skbs
> will never be sent.

Please properly wrap your changelog at 72 columns.

> To fix this, stop to queue skbs and return NETDEV_TX_BUSY only if
> remote wakeup operation is successful.
> 
> Signed-off-by: zhilin.yang <zlyang_001@163.com>

Please use your name, which I doubt has a "." in it, right?  :)

Also, what git commit id does this fix?

thanks,

greg k-h

  reply	other threads:[~2025-05-03 12:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-02 14:53 [PATCH] usb: gadget: u_ether: Continue to send skbs if remote wakeup fails zhilin.yang
2025-05-03 12:30 ` Greg KH [this message]
2025-05-03 14:19   ` Zhilin Yang
2025-05-05  4:32     ` Prashanth K
     [not found]       ` <9debf9b.86d42.1969ee3e6c8.Coremail.zlyang_001@163.com>
2025-05-05  8:53         ` Prashanth K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025050321-apprehend-lavish-ea92@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=zlyang_001@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.