From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: remove the stream_status member from scsi_stream_status_header
Date: Mon, 5 May 2025 08:06:33 +0200 [thread overview]
Message-ID: <20250505060633.GA21601@lst.de> (raw)
In-Reply-To: <399f47d3-2a78-4321-98c0-990f35dc0f9a@acm.org>
On Sat, May 03, 2025 at 12:05:46PM -0700, Bart Van Assche wrote:
> There is an implicit assumption behind this patch, namely that the compiler
> does not insert padding bytes between struct
> scsi_stream_status_header and struct scsi_stream_status. Shouldn't this be
> made explicit with a BUILD_BUG_ON() expression?
We make that assumption for all our naturally alignend structures
in every on-disk and on the wire structure.
next prev parent reply other threads:[~2025-05-05 6:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 18:16 [PATCH] scsi: remove the stream_status member from scsi_stream_status_header Christoph Hellwig
2025-05-02 11:30 ` John Garry
2025-05-03 19:05 ` Bart Van Assche
2025-05-05 6:06 ` Christoph Hellwig [this message]
2025-05-04 3:08 ` Bart Van Assche
-- strict thread matches above, loose matches on Subject: below --
2025-05-05 6:06 Christoph Hellwig
2025-05-05 16:50 ` Bart Van Assche
2025-05-13 2:17 ` Martin K. Petersen
2025-05-21 2:19 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505060633.GA21601@lst.de \
--to=hch@lst.de \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.