From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Marco Crivellari <marco.crivellari@suse.com>
Cc: linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH 0/4] Workqueue: rename system workqueue and add WQ_PERCPU
Date: Mon, 5 May 2025 08:51:21 +0200 [thread overview]
Message-ID: <20250505065121.dlEw6_SC@linutronix.de> (raw)
In-Reply-To: <20250503082834.49413-1-marco.crivellari@suse.com>
On 2025-05-03 10:28:30 [+0200], Marco Crivellari wrote:
> Hi!
Hi,
> This series is the follow up of the discussion from:
> "workqueue: Always use wq_select_unbound_cpu() for WORK_CPU_UNBOUND."
> https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/
>
> 1) [P 1-2] system workqueue rename:
>
> system_wq is a per-CPU workqueue, but his name is not clear.
> system_unbound_wq is to be used when locality is not required.
>
> system_wq renamed in system_percpu_wq, while system_unbound_wq
> became system_dfl_wq.
>
> 2) [P 3] Introduction of WQ_PERCPU.
>
> This patch adds a new WQ_PERCPU flag to explicitly request the legacy
> per-CPU behavior. WQ_UNBOUND will be removed once the migration is
> complete.
>
> Every alloc_workqueue() caller should use one among WQ_PERCPU or
> WQ_UNBOUND. This is actually enforced warning if both or none of them
> are present at the same time.
>
> 3) [P 4] alloc_workqueue() callee should pass explicitly WQ_PERCPU.
>
> This patch ensures that every caller that needs per-cpu workqueue
> will explicitly require it, using the WQ_PERCPU flag.
Sounds like a plan.
I assume the huge patches were made with coccinelle?
Sebastian
next prev parent reply other threads:[~2025-05-05 6:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-03 8:28 [PATCH 0/4] Workqueue: rename system workqueue and add WQ_PERCPU Marco Crivellari
2025-05-03 8:28 ` [PATCH 1/4] Workqueue: rename system_wq to system_percpu_wq Marco Crivellari
2025-05-03 8:28 ` [PATCH 2/4] Workqueue: rename system_unbound_wq to system_dfl_wq Marco Crivellari
2025-05-03 8:28 ` [PATCH 3/4] Workqueue: add WQ_PERCPU Marco Crivellari
2025-05-03 8:28 ` [PATCH 4/4] Workqueue: add WQ_PERCPU to every alloc_workqueue user Marco Crivellari
2025-05-05 6:56 ` Sebastian Andrzej Siewior
2025-05-05 9:22 ` Michal Hocko
2025-05-06 12:36 ` Frederic Weisbecker
2025-05-05 6:51 ` Sebastian Andrzej Siewior [this message]
2025-05-05 7:55 ` [PATCH 0/4] Workqueue: rename system workqueue and add WQ_PERCPU Marco Crivellari
2025-05-05 9:25 ` Michal Hocko
2025-05-06 7:53 ` Marco Crivellari
2025-05-05 23:39 ` Tejun Heo
2025-05-06 10:10 ` Marco Crivellari
2025-05-06 12:55 ` Frederic Weisbecker
2025-05-07 0:42 ` Tejun Heo
2025-05-07 12:04 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505065121.dlEw6_SC@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.