From: Jakub Kicinski <kuba@kernel.org>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 2/5] net: vertexcom: mse102x: Add warning about IRQ trigger type
Date: Mon, 5 May 2025 13:57:11 -0700 [thread overview]
Message-ID: <20250505135711.742cd759@kernel.org> (raw)
In-Reply-To: <20250505142427.9601-3-wahrenst@gmx.net>
On Mon, 5 May 2025 16:24:24 +0200 Stefan Wahren wrote:
> The example of the initial DT binding of the Vertexcom MSE 102x suggested
> a IRQ_TYPE_EDGE_RISING, which is wrong. So warn everyone to fix their
> device tree to level based IRQ.
Doesn't build on x86:
drivers/net/ethernet/vertexcom/mse102x.c:535:10: note: did you mean 'led_get_trigger_data'?
include/linux/leds.h:544:21: note: 'led_get_trigger_data' declared here
544 | static inline void *led_get_trigger_data(struct led_classdev *led_cdev)
| ^
drivers/net/ethernet/vertexcom/mse102x.c:536:7: error: use of undeclared identifier 'IRQ_TYPE_LEVEL_HIGH'
536 | case IRQ_TYPE_LEVEL_HIGH:
| ^
drivers/net/ethernet/vertexcom/mse102x.c:537:7: error: use of undeclared identifier 'IRQ_TYPE_LEVEL_LOW'
537 | case IRQ_TYPE_LEVEL_LOW:
| ^
--
pw-bot: cr
next prev parent reply other threads:[~2025-05-05 20:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 14:24 [PATCH net-next 0/5] net: vertexcom: mse102x: Improve RX handling Stefan Wahren
2025-05-05 14:24 ` [PATCH net-next 1/5] dt-bindings: vertexcom-mse102x: Fix IRQ type in example Stefan Wahren
2025-05-05 16:31 ` Andrew Lunn
2025-05-05 14:24 ` [PATCH net-next 2/5] net: vertexcom: mse102x: Add warning about IRQ trigger type Stefan Wahren
2025-05-05 16:32 ` Andrew Lunn
2025-05-06 8:38 ` Stefan Wahren
2025-05-06 12:24 ` Andrew Lunn
2025-05-05 20:57 ` Jakub Kicinski [this message]
2025-05-07 10:25 ` kernel test robot
2025-05-07 14:35 ` Stefan Wahren
2025-05-08 9:00 ` kernel test robot
2025-05-05 14:24 ` [PATCH net-next 3/5] net: vertexcom: mse102x: Drop invalid cmd stats Stefan Wahren
2025-05-05 16:35 ` Andrew Lunn
2025-05-05 17:28 ` Stefan Wahren
2025-05-05 14:24 ` [PATCH net-next 4/5] net: vertexcom: mse102x: Return code for mse102x_rx_pkt_spi Stefan Wahren
2025-05-05 16:43 ` Andrew Lunn
2025-05-05 17:16 ` Stefan Wahren
2025-05-05 19:27 ` Andrew Lunn
2025-05-06 8:24 ` Stefan Wahren
2025-05-05 14:24 ` [PATCH net-next 5/5] net: vertexcom: mse102x: Simplify mse102x_rx_pkt_spi Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505135711.742cd759@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.