From: Jakub Kicinski <kuba@kernel.org>
To: Keith Busch <kbusch@kernel.org>
Cc: Gustavo Padovan <gus@collabora.com>,
Aurelien Aptel <aaptel@nvidia.com>,
linux-nvme <linux-nvme@lists.infradead.org>,
netdev <netdev@vger.kernel.org>, sagi <sagi@grimberg.me>,
hch <hch@lst.de>, axboe <axboe@fb.com>,
chaitanyak <chaitanyak@nvidia.com>, davem <davem@davemloft.net>,
"aurelien.aptel" <aurelien.aptel@gmail.com>,
smalin <smalin@nvidia.com>, malin1024 <malin1024@gmail.com>,
ogerlitz <ogerlitz@nvidia.com>, yorayz <yorayz@nvidia.com>,
borisp <borisp@nvidia.com>, galshalom <galshalom@nvidia.com>,
mgurtovoy <mgurtovoy@nvidia.com>, tariqt <tariqt@nvidia.com>,
edumazet <edumazet@google.com>
Subject: Re: [PATCH v28 00/20] nvme-tcp receive offloads
Date: Mon, 5 May 2025 15:51:30 -0700 [thread overview]
Message-ID: <20250505155130.6e588cdf@kernel.org> (raw)
In-Reply-To: <aBky09WRujm8KmEC@kbusch-mbp.dhcp.thefacebook.com>
On Mon, 5 May 2025 15:51:15 -0600 Keith Busch wrote:
> On Mon, May 05, 2025 at 01:43:34PM -0700, Jakub Kicinski wrote:
> > Looks like the tests passed? But we'll drop this from our PW, again.
> > Christoph Hellwig was pushing back on the v27. We can't do anything
> > with these until NVMe people are all happy.
>
> FWIW, I believe Sagi is okay with this as he has reviewed or acked all
> the patches. I am also okay with this, though I'm more or less neutral
> on the whole since it's outside my scope, but the nvme parts look fine.
> The new additions are isolated to hardware that provides these offloads,
> so I'm not really concerned this is going to be a problem maintaining
> with the existing nvme-tcp driver. I trust in Sagi on this one.
Thanks, so we have two "yes" votes. Let's give it a week and if there
are no vetoes / nacks we can start.. chasing TCP maintainers for an ack?
next prev parent reply other threads:[~2025-05-06 2:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 8:57 [PATCH v28 00/20] nvme-tcp receive offloads Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 01/20] net: Introduce direct data placement tcp offload Aurelien Aptel
2025-05-14 7:12 ` Eric Dumazet
2025-05-16 14:47 ` Aurelien Aptel
2025-05-16 22:31 ` Jakub Kicinski
2025-05-17 7:38 ` Eric Dumazet
2025-05-22 15:01 ` Aurelien Aptel
2025-06-04 12:33 ` Aurelien Aptel
2025-06-04 12:55 ` Eric Dumazet
2025-06-05 11:54 ` Aurelien Aptel
2025-06-05 12:44 ` Eric Dumazet
2025-04-30 8:57 ` [PATCH v28 02/20] netlink: add new family to manage ULP_DDP enablement and stats Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 03/20] iov_iter: skip copy if src == dst for direct data placement Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 04/20] net/tls,core: export get_netdev_for_sock Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 05/20] nvme-tcp: Add DDP offload control path Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 06/20] nvme-tcp: Add DDP data-path Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 07/20] nvme-tcp: RX DDGST offload Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 08/20] nvme-tcp: Deal with netdevice DOWN events Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 09/20] Documentation: add ULP DDP offload documentation Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 10/20] net/mlx5e: Rename from tls to transport static params Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 11/20] net/mlx5e: Refactor ico sq polling to get budget Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 12/20] net/mlx5: Add NVMEoTCP caps, HW bits, 128B CQE and enumerations Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 13/20] net/mlx5e: NVMEoTCP, offload initialization Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 14/20] net/mlx5e: TCP flow steering for nvme-tcp acceleration Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 15/20] net/mlx5e: NVMEoTCP, use KLM UMRs for buffer registration Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 16/20] net/mlx5e: NVMEoTCP, queue init/teardown Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 17/20] net/mlx5e: NVMEoTCP, ddp setup and resync Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 18/20] net/mlx5e: NVMEoTCP, async ddp invalidation Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 19/20] net/mlx5e: NVMEoTCP, data-path for DDP+DDGST offload Aurelien Aptel
2025-04-30 8:57 ` [PATCH v28 20/20] net/mlx5e: NVMEoTCP, statistics Aurelien Aptel
2025-04-30 12:52 ` [PATCH v28 00/20] nvme-tcp receive offloads Gustavo Padovan
2025-05-05 20:43 ` Jakub Kicinski
2025-05-05 21:51 ` Keith Busch
2025-05-05 22:51 ` Jakub Kicinski [this message]
2025-05-13 12:56 ` Aurelien Aptel
2025-05-13 14:36 ` Jakub Kicinski
2025-05-06 13:34 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505155130.6e588cdf@kernel.org \
--to=kuba@kernel.org \
--cc=aaptel@nvidia.com \
--cc=aurelien.aptel@gmail.com \
--cc=axboe@fb.com \
--cc=borisp@nvidia.com \
--cc=chaitanyak@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=galshalom@nvidia.com \
--cc=gus@collabora.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=malin1024@gmail.com \
--cc=mgurtovoy@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@nvidia.com \
--cc=sagi@grimberg.me \
--cc=smalin@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=yorayz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.