All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Jonas Karlman <jonas@kwiboo.se>,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Eddie James <eajames@linux.ibm.com>,
	Matthew Garrett <mgarrett@aurora.tech>,
	Mattijs Korpershoek <mkorpershoek@baylibre.com>,
	Quentin Schulz <quentin.schulz@cherry.de>,
	Sughosh Ganu <sughosh.ganu@linaro.org>
Subject: Re: [PATCH v2 0/3] booti: Remove the SYS_BOOTM_LEN limit for booti
Date: Mon, 5 May 2025 12:14:21 -0600	[thread overview]
Message-ID: <20250505181421.GI5430@bill-the-cat> (raw)
In-Reply-To: <20250501131858.2160756-1-sjg@chromium.org>

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

On Thu, May 01, 2025 at 07:18:32AM -0600, Simon Glass wrote:

> This series restores the original behaviour of extlinux booting linux
> 'Image' files, which is to ignore CONFIG_SYS_BOOTM_LEN and instead uses
> a limit of 10x the compressed size.
> 
> It also adds RISC-V support, since it uses a similar format to ARM64.
> 
> Future work should integrate the code in 'booti' into main 'bootm'
> logic.

I don't like "in the future we'll remove duplicated code". I also don't
like not seeing that what we really need to do, in all cases (not just
booti) handle decompression like we do for FIT images, and ask LMB to
give us a space to use. A problem is that CONFIG_SYS_BOOTM_LEN was never
intended to be the limit on *decompression* as it's the limit on what
we're loading to memory from disk. That's what getting me unhappy with
this part of the series.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  parent reply	other threads:[~2025-05-05 18:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-01 13:18 [PATCH v2 0/3] booti: Remove the SYS_BOOTM_LEN limit for booti Simon Glass
2025-05-01 13:18 ` [PATCH v2 1/3] boot: Add a function to check if a linux Image is supported Simon Glass
2025-05-05 13:45   ` Tom Rini
2025-05-01 13:18 ` [PATCH v2 2/3] bootm: Add RISC-V support in booti_is_supported() Simon Glass
2025-05-05 15:07   ` Tom Rini
2025-05-01 13:18 ` [PATCH v2 3/3] booti: Allow using 10x the uncompressed size with booti Simon Glass
2025-05-05 18:14 ` Tom Rini [this message]
2025-05-06 13:24   ` [PATCH v2 0/3] booti: Remove the SYS_BOOTM_LEN limit for booti Simon Glass
2025-05-06 16:32     ` Tom Rini
2025-05-10 11:25       ` Simon Glass
2025-05-12 22:30         ` Tom Rini
2025-05-14 19:39           ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250505181421.GI5430@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=eajames@linux.ibm.com \
    --cc=jonas@kwiboo.se \
    --cc=mgarrett@aurora.tech \
    --cc=mkorpershoek@baylibre.com \
    --cc=quentin.schulz@cherry.de \
    --cc=sjg@chromium.org \
    --cc=sughosh.ganu@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.