From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] metaparse: ignore macros in tst_test structure parsing
Date: Mon, 5 May 2025 21:58:20 +0200 [thread overview]
Message-ID: <20250505195820.GD137650@pevik> (raw)
In-Reply-To: <20250505151235.12898-1-chrubis@suse.cz>
Hi Cyril,
> All we need to do is to drop all lines starting with '#'.
LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
It'd make sense to mention why you need it - to ignore e.g.
#ifdef __x86_64__
(I first thought where it was needed, but it's a preparation for the cleanup you
proposed in
http://patchwork.ozlabs.org/project/ltp/patch/20250429135542.19680-1-chrubis@suse.cz/ ).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-05-05 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 15:12 [LTP] [PATCH] metaparse: ignore macros in tst_test structure parsing Cyril Hrubis
2025-05-05 19:58 ` Petr Vorel [this message]
2025-05-06 9:43 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505195820.GD137650@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.