From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C81DC399EA9; Mon, 5 May 2025 23:21:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487292; cv=none; b=aUAr0uXh5cp2Ql951h+8RCDtNkxqXM8BbvdJO/KRgG/kiFGPiLk5bzXqevNopk3MmarrbfiCBmXgZX5/eh0eVHJeF1BKxfWEQs85xg6reA+7jr1s3T6pjPX12BAdc7/A++ss4Isv5c/t5C2AbT/xY4HCNrMASiypfcLyf18LzRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487292; c=relaxed/simple; bh=Wk8A/TFanfnUX6PPFZ06TxUBfJeUepmngh2kB5ySzhs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SGKzsZDdqccHTENOmr7GaaJun8nrftliUOGWwFiJtcepUdo8fRPCGK0ss2sXPP9pEYu6jbRT/i5niFM9+Sr6ZDEevmCz+70DB9JgN3mmvNsANV6OwQqVs+uw6JKQzXmCErMv93paSSkHprULp4F63qAqvvX7WtDVTvlAIxJEHoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p8KAg0gX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p8KAg0gX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFC87C4CEED; Mon, 5 May 2025 23:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746487292; bh=Wk8A/TFanfnUX6PPFZ06TxUBfJeUepmngh2kB5ySzhs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p8KAg0gX8ejrspRj58Lrt8ycI1U2wWhn7T3D0tjs1KqbGQoAahXwcQPkxSK0zAETT dzqCNGdTcs4zQqxOHD85X+nhMj2dGjgPUcILb+HQWuw1zZkt/EXXWmQ8xwUU0tLhxD akRI5FB7kSx9d5LYaZtOWHBi52QI34dUt2N6yKaspgvaZ6ca4biwMfILKxQTDXvSvx 34hFBsNyFWSITZy557XCL0Dr9DwuoBa5I7dkPHhOywZOcI52XNn9xgpALu0fnZSEJt sxaCHeLdXUDC9G1Zr7J45ymoLrQTSgRXZ7DEWda0dZTvfkJQifCDqWq/lp5TLLn3B7 vh0emPb6RFa2g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ankur Arora , "Paul E . McKenney" , Sebastian Andrzej Siewior , Frederic Weisbecker , Boqun Feng , Sasha Levin , neeraj.upadhyay@kernel.org, joel@joelfernandes.org, josh@joshtriplett.org, urezki@gmail.com, rcu@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 102/114] rcu: handle quiescent states for PREEMPT_RCU=n, PREEMPT_COUNT=y Date: Mon, 5 May 2025 19:18:05 -0400 Message-Id: <20250505231817.2697367-102-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505231817.2697367-1-sashal@kernel.org> References: <20250505231817.2697367-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: rcu@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.237 Content-Transfer-Encoding: 8bit From: Ankur Arora [ Upstream commit 83b28cfe796464ebbde1cf7916c126da6d572685 ] With PREEMPT_RCU=n, cond_resched() provides urgently needed quiescent states for read-side critical sections via rcu_all_qs(). One reason why this was needed: lacking preempt-count, the tick handler has no way of knowing whether it is executing in a read-side critical section or not. With (PREEMPT_LAZY=y, PREEMPT_DYNAMIC=n), we get (PREEMPT_COUNT=y, PREEMPT_RCU=n). In this configuration cond_resched() is a stub and does not provide quiescent states via rcu_all_qs(). (PREEMPT_RCU=y provides this information via rcu_read_unlock() and its nesting counter.) So, use the availability of preempt_count() to report quiescent states in rcu_flavor_sched_clock_irq(). Suggested-by: Paul E. McKenney Reviewed-by: Sebastian Andrzej Siewior Signed-off-by: Ankur Arora Reviewed-by: Frederic Weisbecker Signed-off-by: Paul E. McKenney Signed-off-by: Boqun Feng Signed-off-by: Sasha Levin --- kernel/rcu/tree_plugin.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h index f5ba0740f9b50..c07a841971739 100644 --- a/kernel/rcu/tree_plugin.h +++ b/kernel/rcu/tree_plugin.h @@ -919,13 +919,16 @@ static void rcu_preempt_check_blocked_tasks(struct rcu_node *rnp) */ static void rcu_flavor_sched_clock_irq(int user) { - if (user || rcu_is_cpu_rrupt_from_idle()) { + if (user || rcu_is_cpu_rrupt_from_idle() || + (IS_ENABLED(CONFIG_PREEMPT_COUNT) && + (preempt_count() == HARDIRQ_OFFSET))) { /* * Get here if this CPU took its interrupt from user - * mode or from the idle loop, and if this is not a - * nested interrupt. In this case, the CPU is in - * a quiescent state, so note it. + * mode, from the idle loop without this being a nested + * interrupt, or while not holding the task preempt count + * (with PREEMPT_COUNT=y). In this case, the CPU is in a + * quiescent state, so note it. * * No memory barrier is required here because rcu_qs() * references only CPU-local variables that other CPUs -- 2.39.5