From: <gregkh@linuxfoundation.org>
To: catherine.hoang@oracle.com,chandan.babu@oracle.com,chandanbabu@kernel.org,djwong@kernel.org,gregkh@linuxfoundation.org,hch@lst.de,leah.rumancik@gmail.com,xfs-stable@lists.linux.dev,yi.zhang@huawei.com
Cc: <stable-commits@vger.kernel.org>
Subject: Patch "xfs: match lock mode in xfs_buffered_write_iomap_begin()" has been added to the 6.1-stable tree
Date: Mon, 05 May 2025 11:18:25 +0200 [thread overview]
Message-ID: <2025050524-ascertain-estrogen-9074@gregkh> (raw)
In-Reply-To: <20250430212704.2905795-9-leah.rumancik@gmail.com>
This is a note to let you know that I've just added the patch titled
xfs: match lock mode in xfs_buffered_write_iomap_begin()
to the 6.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
xfs-match-lock-mode-in-xfs_buffered_write_iomap_begin.patch
and it can be found in the queue-6.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
From stable+bounces-139235-greg=kroah.com@vger.kernel.org Wed Apr 30 23:32:51 2025
From: Leah Rumancik <leah.rumancik@gmail.com>
Date: Wed, 30 Apr 2025 14:26:55 -0700
Subject: xfs: match lock mode in xfs_buffered_write_iomap_begin()
To: stable@vger.kernel.org
Cc: xfs-stable@lists.linux.dev, chandan.babu@oracle.com, catherine.hoang@oracle.com, djwong@kernel.org, Zhang Yi <yi.zhang@huawei.com>, Christoph Hellwig <hch@lst.de>, Chandan Babu R <chandanbabu@kernel.org>, Leah Rumancik <leah.rumancik@gmail.com>
Message-ID: <20250430212704.2905795-9-leah.rumancik@gmail.com>
From: Zhang Yi <yi.zhang@huawei.com>
[ Upstream commit bb712842a85d595525e72f0e378c143e620b3ea2 ]
Commit 1aa91d9c9933 ("xfs: Add async buffered write support") replace
xfs_ilock(XFS_ILOCK_EXCL) with xfs_ilock_for_iomap() when locking the
writing inode, and a new variable lockmode is used to indicate the lock
mode. Although the lockmode should always be XFS_ILOCK_EXCL, it's still
better to use this variable instead of useing XFS_ILOCK_EXCL directly
when unlocking the inode.
Fixes: 1aa91d9c9933 ("xfs: Add async buffered write support")
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com>
Acked-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
fs/xfs/xfs_iomap.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--- a/fs/xfs/xfs_iomap.c
+++ b/fs/xfs/xfs_iomap.c
@@ -1129,13 +1129,13 @@ retry:
* them out if the write happens to fail.
*/
seq = xfs_iomap_inode_sequence(ip, IOMAP_F_NEW);
- xfs_iunlock(ip, XFS_ILOCK_EXCL);
+ xfs_iunlock(ip, lockmode);
trace_xfs_iomap_alloc(ip, offset, count, allocfork, &imap);
return xfs_bmbt_to_iomap(ip, iomap, &imap, flags, IOMAP_F_NEW, seq);
found_imap:
seq = xfs_iomap_inode_sequence(ip, 0);
- xfs_iunlock(ip, XFS_ILOCK_EXCL);
+ xfs_iunlock(ip, lockmode);
return xfs_bmbt_to_iomap(ip, iomap, &imap, flags, 0, seq);
found_cow:
@@ -1145,17 +1145,17 @@ found_cow:
if (error)
goto out_unlock;
seq = xfs_iomap_inode_sequence(ip, IOMAP_F_SHARED);
- xfs_iunlock(ip, XFS_ILOCK_EXCL);
+ xfs_iunlock(ip, lockmode);
return xfs_bmbt_to_iomap(ip, iomap, &cmap, flags,
IOMAP_F_SHARED, seq);
}
xfs_trim_extent(&cmap, offset_fsb, imap.br_startoff - offset_fsb);
- xfs_iunlock(ip, XFS_ILOCK_EXCL);
+ xfs_iunlock(ip, lockmode);
return xfs_bmbt_to_iomap(ip, iomap, &cmap, flags, 0, seq);
out_unlock:
- xfs_iunlock(ip, XFS_ILOCK_EXCL);
+ xfs_iunlock(ip, lockmode);
return error;
}
Patches currently in stable-queue which might be from leah.rumancik@gmail.com are
queue-6.1/xfs-revert-commit-44af6c7e59b12.patch
queue-6.1/xfs-make-the-seq-argument-to-xfs_bmapi_convert_delalloc-optional.patch
queue-6.1/xfs-check-opcode-and-iovec-count-match-in-xlog_recover_attri_commit_pass2.patch
queue-6.1/xfs-allow-symlinks-with-short-remote-targets.patch
queue-6.1/xfs-match-lock-mode-in-xfs_buffered_write_iomap_begin.patch
queue-6.1/xfs-require-xfs_sb_feat_incompat_log_xattrs-for-attr-log-intent-item-recovery.patch
queue-6.1/xfs-allow-unlinked-symlinks-and-dirs-with-zero-size.patch
queue-6.1/xfs-restrict-when-we-try-to-align-cow-fork-delalloc-to-cowextsz-hints.patch
queue-6.1/xfs-fix-xfs_bmap_add_extent_delay_real-for-partial-conversions.patch
queue-6.1/xfs-validate-recovered-name-buffers-when-recovering-xattr-items.patch
queue-6.1/xfs-make-xfs_bmapi_convert_delalloc-to-allocate-the-target-offset.patch
queue-6.1/xfs-convert-delayed-extents-to-unwritten-when-zeroing-post-eof-blocks.patch
queue-6.1/xfs-fix-freeing-speculative-preallocations-for-preallocated-files.patch
queue-6.1/xfs-make-sure-sb_fdblocks-is-non-negative.patch
queue-6.1/xfs-remove-a-racy-if_bytes-check-in-xfs_reflink_end_cow_extent.patch
queue-6.1/xfs-fix-error-returns-from-xfs_bmapi_write.patch
next prev parent reply other threads:[~2025-05-05 9:19 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 21:26 [PATCH 6.1 00/16] xfs backports for 6.1.y from 6.10 Leah Rumancik
2025-04-30 21:26 ` [PATCH 6.1 01/16] xfs: fix error returns from xfs_bmapi_write Leah Rumancik
2025-05-01 18:51 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: fix error returns from xfs_bmapi_write" has been added to the 6.1-stable tree gregkh
2025-04-30 21:26 ` [PATCH 6.1 02/16] xfs: fix xfs_bmap_add_extent_delay_real for partial conversions Leah Rumancik
2025-05-01 19:09 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: fix xfs_bmap_add_extent_delay_real for partial conversions" has been added to the 6.1-stable tree gregkh
2025-04-30 21:26 ` [PATCH 6.1 03/16] xfs: remove a racy if_bytes check in xfs_reflink_end_cow_extent Leah Rumancik
2025-05-01 19:10 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: remove a racy if_bytes check in xfs_reflink_end_cow_extent" has been added to the 6.1-stable tree gregkh
2025-04-30 21:26 ` [PATCH 6.1 04/16] xfs: require XFS_SB_FEAT_INCOMPAT_LOG_XATTRS for attr log intent item recovery Leah Rumancik
2025-05-01 19:10 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: require XFS_SB_FEAT_INCOMPAT_LOG_XATTRS for attr log intent item recovery" has been added to the 6.1-stable tree gregkh
2025-04-30 21:26 ` [PATCH 6.1 05/16] xfs: check opcode and iovec count match in xlog_recover_attri_commit_pass2 Leah Rumancik
2025-05-01 19:09 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: check opcode and iovec count match in xlog_recover_attri_commit_pass2" has been added to the 6.1-stable tree gregkh
2025-04-30 21:26 ` [PATCH 6.1 06/16] xfs: validate recovered name buffers when recovering xattr items Leah Rumancik
2025-05-01 18:51 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: validate recovered name buffers when recovering xattr items" has been added to the 6.1-stable tree gregkh
2025-04-30 21:26 ` [PATCH 6.1 07/16] xfs: revert commit 44af6c7e59b12 Leah Rumancik
2025-05-01 19:09 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: revert commit 44af6c7e59b12" has been added to the 6.1-stable tree gregkh
2025-04-30 21:26 ` [PATCH 6.1 08/16] xfs: match lock mode in xfs_buffered_write_iomap_begin() Leah Rumancik
2025-05-01 19:11 ` Sasha Levin
2025-05-05 9:18 ` gregkh [this message]
2025-04-30 21:26 ` [PATCH 6.1 09/16] xfs: make the seq argument to xfs_bmapi_convert_delalloc() optional Leah Rumancik
2025-05-01 19:11 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: make the seq argument to xfs_bmapi_convert_delalloc() optional" has been added to the 6.1-stable tree gregkh
2025-04-30 21:26 ` [PATCH 6.1 10/16] xfs: make xfs_bmapi_convert_delalloc() to allocate the target offset Leah Rumancik
2025-05-01 18:51 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: make xfs_bmapi_convert_delalloc() to allocate the target offset" has been added to the 6.1-stable tree gregkh
2025-04-30 21:26 ` [PATCH 6.1 11/16] xfs: convert delayed extents to unwritten when zeroing post eof blocks Leah Rumancik
2025-05-01 18:50 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: convert delayed extents to unwritten when zeroing post eof blocks" has been added to the 6.1-stable tree gregkh
2025-04-30 21:26 ` [PATCH 6.1 12/16] xfs: allow symlinks with short remote targets Leah Rumancik
2025-05-01 19:09 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: allow symlinks with short remote targets" has been added to the 6.1-stable tree gregkh
2025-04-30 21:27 ` [PATCH 6.1 13/16] xfs: make sure sb_fdblocks is non-negative Leah Rumancik
2025-05-01 18:50 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: make sure sb_fdblocks is non-negative" has been added to the 6.1-stable tree gregkh
2025-04-30 21:27 ` [PATCH 6.1 14/16] xfs: fix freeing speculative preallocations for preallocated files Leah Rumancik
2025-05-01 19:10 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: fix freeing speculative preallocations for preallocated files" has been added to the 6.1-stable tree gregkh
2025-04-30 21:27 ` [PATCH 6.1 15/16] xfs: allow unlinked symlinks and dirs with zero size Leah Rumancik
2025-05-01 19:09 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: allow unlinked symlinks and dirs with zero size" has been added to the 6.1-stable tree gregkh
2025-04-30 21:27 ` [PATCH 6.1 16/16] xfs: restrict when we try to align cow fork delalloc to cowextsz hints Leah Rumancik
2025-05-01 19:12 ` Sasha Levin
2025-05-05 9:18 ` Patch "xfs: restrict when we try to align cow fork delalloc to cowextsz hints" has been added to the 6.1-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025050524-ascertain-estrogen-9074@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=catherine.hoang@oracle.com \
--cc=chandan.babu@oracle.com \
--cc=chandanbabu@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=leah.rumancik@gmail.com \
--cc=stable-commits@vger.kernel.org \
--cc=xfs-stable@lists.linux.dev \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.