From: "Heyne, Maximilian" <mheyne@amazon.de>
Cc: "Heyne, Maximilian" <mheyne@amazon.de>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Sudeep Holla <sudeep.holla@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] ACPI/PPTT: fix off-by-one error
Date: Tue, 6 May 2025 13:13:02 +0000 [thread overview]
Message-ID: <20250506-draco-taped-15f475cd@mheyne-amazon> (raw)
Commit 7ab4f0e37a0f ("ACPI PPTT: Fix coding mistakes in a couple of
sizeof() calls") corrects the processer entry size but unmasked a longer
standing bug where the last entry in the structure can get skipped due
to an off-by-one mistake if the last entry ends exactly at the end of
the ACPI subtable.
The error manifests for instance on EC2 Graviton Metal instances with
ACPI PPTT: PPTT table found, but unable to locate core 63 (63)
[...]
ACPI: SPE must be homogeneous
Fixes: 2bd00bcd73e5 ("ACPI/PPTT: Add Processor Properties Topology Table parsing")
Cc: stable@vger.kernel.org
Signed-off-by: Maximilian Heyne <mheyne@amazon.de>
---
drivers/acpi/pptt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/pptt.c b/drivers/acpi/pptt.c
index f73ce6e13065d..4364da90902e5 100644
--- a/drivers/acpi/pptt.c
+++ b/drivers/acpi/pptt.c
@@ -231,7 +231,7 @@ static int acpi_pptt_leaf_node(struct acpi_table_header *table_hdr,
sizeof(struct acpi_table_pptt));
proc_sz = sizeof(struct acpi_pptt_processor);
- while ((unsigned long)entry + proc_sz < table_end) {
+ while ((unsigned long)entry + proc_sz <= table_end) {
cpu_node = (struct acpi_pptt_processor *)entry;
if (entry->type == ACPI_PPTT_TYPE_PROCESSOR &&
cpu_node->parent == node_entry)
@@ -273,7 +273,7 @@ static struct acpi_pptt_processor *acpi_find_processor_node(struct acpi_table_he
proc_sz = sizeof(struct acpi_pptt_processor);
/* find the processor structure associated with this cpuid */
- while ((unsigned long)entry + proc_sz < table_end) {
+ while ((unsigned long)entry + proc_sz <= table_end) {
cpu_node = (struct acpi_pptt_processor *)entry;
if (entry->length == 0) {
--
2.47.1
Amazon Web Services Development Center Germany GmbH
Tamara-Danz-Str. 13
10243 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B
Sitz: Berlin
Ust-ID: DE 365 538 597
next reply other threads:[~2025-05-06 13:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 13:13 Heyne, Maximilian [this message]
2025-05-06 13:43 ` [PATCH] ACPI/PPTT: fix off-by-one error Sudeep Holla
2025-05-06 20:08 ` Heyne, Maximilian
2025-05-07 11:52 ` Sudeep Holla
2025-05-07 11:56 ` Heyne, Maximilian
2025-05-07 12:30 ` Sudeep Holla
2025-05-07 12:35 ` Rafael J. Wysocki
2025-05-07 12:42 ` Heyne, Maximilian
2025-05-07 12:50 ` Rafael J. Wysocki
2025-05-07 13:01 ` Sudeep Holla
2025-05-07 12:56 ` Sudeep Holla
2025-05-07 14:29 ` Heyne, Maximilian
2025-05-07 15:12 ` Sudeep Holla
2025-05-06 20:11 ` Jeremy Linton
2025-05-07 11:53 ` Heyne, Maximilian
2025-05-07 11:59 ` Rafael J. Wysocki
2025-05-07 12:17 ` Heyne, Maximilian
2025-05-07 15:25 ` Jeremy Linton
2025-05-07 15:42 ` Rafael J. Wysocki
2025-05-07 15:51 ` Jeremy Linton
2025-05-07 16:12 ` Rafael J. Wysocki
2025-05-07 16:28 ` Sudeep Holla
2025-05-07 16:31 ` Jeremy Linton
2025-05-07 16:38 ` Jeremy Linton
2025-05-07 16:41 ` Jeremy Linton
2025-05-07 17:01 ` Rafael J. Wysocki
2025-05-07 17:35 ` Jeremy Linton
2025-05-07 17:59 ` Jeremy Linton
2025-05-07 15:47 ` Sudeep Holla
2025-05-07 15:52 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250506-draco-taped-15f475cd@mheyne-amazon \
--to=mheyne@amazon.de \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=jeremy.linton@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.