From: Tom Rini <trini@konsulko.com>
To: Rasmus Villemoes <ravi@prevas.dk>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 00/11] regex patches
Date: Tue, 6 May 2025 10:44:36 -0600 [thread overview]
Message-ID: <20250506164436.GZ5430@bill-the-cat> (raw)
In-Reply-To: <20250506141035.385756-1-ravi@prevas.dk>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Tue, May 06, 2025 at 04:10:24PM +0200, Rasmus Villemoes wrote:
> This started as a rather simple patch, 1/11, adding the ability to
> more conveniently do regex matching in shell.
>
> But with that, it became very easy to see what the slre library can
> and especially what it cannot do, and that way I found both outright
> bugs and a "wow, doesn't it support that syntax" gotcha. I couldn't
> find any tests ('git grep slre -- test/' was empty), so I added a
> small test suite and tweaked slre.c.
I will say I worry there might be users depending on the bugs you've
fixed here, but I don't think that's a reason to not fix the bugs. We
can if needed deal with bug compatibility some opt-in way if required in
the future. And yes, this is a note to anyone in the future that has hit
upon the problem.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2025-05-06 16:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 14:10 [PATCH 00/11] regex patches Rasmus Villemoes
2025-05-06 14:10 ` [PATCH 01/11] cmd: test: add support for =~ operator Rasmus Villemoes
2025-05-06 16:49 ` Tom Rini
2025-05-06 16:52 ` Tom Rini
2025-05-06 19:07 ` Rasmus Villemoes
2025-05-06 19:24 ` Tom Rini
2025-05-06 21:10 ` Rasmus Villemoes
2025-05-06 14:10 ` [PATCH 02/11] slre: add myself as maintainer Rasmus Villemoes
2025-05-06 14:10 ` [PATCH 03/11] test: slre: add tests for regex library Rasmus Villemoes
2025-05-06 14:10 ` [PATCH 04/11] slre: drop wrong "anchored" optimization Rasmus Villemoes
2025-05-06 14:10 ` [PATCH 05/11] test: slre: add more test cases Rasmus Villemoes
2025-05-06 14:10 ` [PATCH 06/11] test: slre: add some (negative) character class tests Rasmus Villemoes
2025-05-06 14:10 ` [PATCH 07/11] slre: refactor is_any_but() Rasmus Villemoes
2025-05-06 14:10 ` [PATCH 08/11] slre: fix matching of escape sequence used inside character class Rasmus Villemoes
2025-05-06 14:10 ` [PATCH 09/11] test: slre: add test cases for escape char in " Rasmus Villemoes
2025-05-06 14:10 ` [PATCH 10/11] slre: implement support for ranges in character classes Rasmus Villemoes
2025-05-06 14:10 ` [PATCH 11/11] test: slre: add tests for character ranges Rasmus Villemoes
2025-05-06 16:44 ` Tom Rini [this message]
2025-05-10 11:25 ` [PATCH 00/11] regex patches Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250506164436.GZ5430@bill-the-cat \
--to=trini@konsulko.com \
--cc=ravi@prevas.dk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.