Re: [PATCH v1 net-next] net: lan743x: configure interrupt moderation timers based on speed

[Jakub Kicinski <kuba@kernel.org>]

On Tue, 6 May 2025 14:10:09 +0200 Andrew Lunn wrote:
> > We've tuned the interrupt moderation values based on testing to improve
> > performance. For now, we’ll keep these fixed values optimized for
> > performance across all speeds. That said, we agree that adding ethtool
> > -c/-C support would provide valuable flexibility for users to balance
> > power and performance, and we’ll consider implementing that in a future
> > update.  
> 
> As you said, you have optimised for performance. That might cause
> regressions for some users. We try to avoid regressions, and if
> somebody does report a regression, we will have to revert this change.
> If you were to implement this ethtool option, we are a lot less likely
> to make a revert, we can instruct the user how to set the coalesce for
> there use case.

I completely agree. Please let the users decide how they want to balance
throughput vs latency.
-- 
pw-bot: cr