From: Kees Cook <kees@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Alejandro Colomar <alx@kernel.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] EISA: Move devlist.h out of obj to always
Date: Tue, 6 May 2025 19:05:15 -0700 [thread overview]
Message-ID: <202505061904.BEFEDC8@keescook> (raw)
In-Reply-To: <98d34958-e57e-40df-9196-920d40fd57f9@infradead.org>
On Tue, May 06, 2025 at 08:54:29AM -0700, Randy Dunlap wrote:
> Hi Kees,
>
> On 4/22/25 8:50 PM, Randy Dunlap wrote:
> >
> >
> > On 4/22/25 7:37 PM, Kees Cook wrote:
> >> I put devlist.h into the wrong Makefile macro ("obj") to get it included
> >> in "targets". Put it into "always" so nothing tries to link against it.
> >> Solves CONFIG_EISA=y i386 build failure:
> >>
> >> ld: vmlinux.a: member drivers/eisa/devlist.h in archive is not an object
> >>
> >> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> >> Closes: https://lore.kernel.org/all/4a8ba1d0-d2d9-41f8-abf1-d45ec8996d10@infradead.org
> >> Fixes: dd09eb0e2cc4 ("EISA: Increase length of device names")
> >> Signed-off-by: Kees Cook <kees@kernel.org>
> >
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > Tested-by: Randy Dunlap <rdunlap@infradead.org>
> >
> > Thanks.
> >
>
> Please merge this patch. The build failure is killing lots of i386 builds.
> Thanks.
Greg, please take this into your -next tree. The commit it fixes isn't
in Linus's tree, so I don't have any way to land it sanely in -next.
-Kees
--
Kees Cook
prev parent reply other threads:[~2025-05-07 2:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 2:37 [PATCH] EISA: Move devlist.h out of obj to always Kees Cook
2025-04-23 3:50 ` Randy Dunlap
2025-05-06 15:54 ` Randy Dunlap
2025-05-06 18:51 ` Kees Cook
2025-05-06 19:17 ` Randy Dunlap
2025-05-07 5:00 ` Greg Kroah-Hartman
2025-05-07 2:05 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202505061904.BEFEDC8@keescook \
--to=kees@kernel.org \
--cc=alx@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.