From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 822D8C369DC for ; Wed, 7 May 2025 07:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=srsDGc/DlCPMp0TFzUJst/uV8AJCyUhZxTzACxx4jPY=; b=HZNxaOOzRA/MFuCBshIitpv/j7 8pS4IaAgZTWrs3ocLk67PACXhJk7NjU2+5QEsDD7RZ4cRFC04ZMA+rqpvVXCMHS1GsJv0N/+QOtmw 6FSt102hcSR692uywf42vZ4fseUVVOfpD/G9k4eO86dDfJKN1LldDgGFmxFh0lGMz7QA=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uCYvA-0002Nh-0l; Wed, 07 May 2025 07:10:24 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uCYv8-0002N7-BU for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 May 2025 07:10:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VPwga5KpIE2aVMvQjivhMpW7fXdT1gYlJZ1wQwuDdng=; b=hvNLT2s43lfcB+CZhPty3wRF6O xdiMfYv2YVdQn15q8URUuwpJh2fk96KQQuMhM5eFcSf2NirzQQo2Gfv1zpdgVShOIUhcymuGVmmb+ S3SEfxgpRfVvStTCglh0YrznfqU12m7rkmpec4SrOmH4LKNxnefTPqzoXtVWWHZ8yqFk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VPwga5KpIE2aVMvQjivhMpW7fXdT1gYlJZ1wQwuDdng=; b=ARwwCNT5SsarKajwOaapxAulvw g0xL9m3MWdrzgTaxcKb+5aBV13aQmM00HdQCWKlX1xOtZ7C8XXm5recVO+csKVUudLxAIjCK8CT8W b/Y8PWqDw1An1O59lZy9aVvX/NLob2/A87JTnLB9dJsLaIOOqx06d5/ys8Ab0nvvG7/U=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uCYuo-0001xd-MV for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 May 2025 07:10:18 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 21B5F68B05; Wed, 7 May 2025 08:44:38 +0200 (CEST) Date: Wed, 7 May 2025 08:44:37 +0200 From: Christoph Hellwig To: Chao Yu Message-ID: <20250507064437.GA31135@lst.de> References: <20250505092613.3451524-1-hch@lst.de> <20250505092613.3451524-3-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1uCYuo-0001xd-MV Subject: Re: [f2fs-dev] [PATCH 2/4] f2fs: don't return AOP_WRITEPAGE_ACTIVATE from f2fs_write_single_data_page X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, May 07, 2025 at 02:28:55PM +0800, Chao Yu wrote: > > diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c > > index e016b0f96313..ce63b3bfb28f 100644 > > --- a/fs/f2fs/compress.c > > +++ b/fs/f2fs/compress.c > > @@ -1565,10 +1565,7 @@ static int f2fs_write_raw_pages(struct compress_ctx *cc, > > NULL, NULL, wbc, io_type, > > compr_blocks, false); > > if (ret) { > > - if (ret == AOP_WRITEPAGE_ACTIVATE) { > > - folio_unlock(folio); > > - ret = 0; > > Previously, for this case, it will goto out label rather than writing > left pages? Indeed. Is that the right thing to do here? _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A715D1D432D for ; Wed, 7 May 2025 06:44:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746600290; cv=none; b=A9CuKp3F6HWtoORXtayJoAFTrpgsQG1h3iMieEoI1zQQMyk/UvEbMrpm7gJnqs1a/Ftx2/hVJyeNL/7fvi1KsZ/CkFoHn9U3CuDD7rmBrQlsWRnTLFHONJky7ovbR1iBF1ocMhHcMsbBGV7Iv2Nk6JWfCqSpwuQOAiwZ1PDS21k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746600290; c=relaxed/simple; bh=UHXgnW/IIlqCSxjGxw37n20//RN/33kKPJ6RqDTbA2I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e+gqQ6KoGapHpLuATOLVk+Iy2BeJlfNC5H15XlY6cQtEgwrM+GTyDSVfJcHa0lIKLs0iIb8YhT3YxoQbMPJ3YKu4QGdRxbe3SE3FRvAR5J8aeIj9/TSJVvazPEGZScMHfJ/cVweINXx2f79D7vMSnyVv8svtzYDj5L0jRx9I1A8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 21B5F68B05; Wed, 7 May 2025 08:44:38 +0200 (CEST) Date: Wed, 7 May 2025 08:44:37 +0200 From: Christoph Hellwig To: Chao Yu Cc: Christoph Hellwig , Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] f2fs: don't return AOP_WRITEPAGE_ACTIVATE from f2fs_write_single_data_page Message-ID: <20250507064437.GA31135@lst.de> References: <20250505092613.3451524-1-hch@lst.de> <20250505092613.3451524-3-hch@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, May 07, 2025 at 02:28:55PM +0800, Chao Yu wrote: > > diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c > > index e016b0f96313..ce63b3bfb28f 100644 > > --- a/fs/f2fs/compress.c > > +++ b/fs/f2fs/compress.c > > @@ -1565,10 +1565,7 @@ static int f2fs_write_raw_pages(struct compress_ctx *cc, > > NULL, NULL, wbc, io_type, > > compr_blocks, false); > > if (ret) { > > - if (ret == AOP_WRITEPAGE_ACTIVATE) { > > - folio_unlock(folio); > > - ret = 0; > > Previously, for this case, it will goto out label rather than writing > left pages? Indeed. Is that the right thing to do here?