From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4ED0C3ABC0 for ; Wed, 7 May 2025 07:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JxYHbY3b+vdqcbHdJO+Uths4BYoe1Pk7uoqPeIJrXIg=; b=W30GHsFdneQYwpiWSUAXFJhHXb SKhKLbh8R1Wb0qkAQxHAPj7yVLBt+hgHdntT46/z62STcQ5jmZuWhKFWV1K7Yd7vUpW3uRHH3hg0t A1I1boBcqwUOhMJGUkapyIeTrGGOJgXKt9VbMcu+a3+5Pb3IxEGG2zxfIfMKzLEprQik=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uCZWU-00030m-1t; Wed, 07 May 2025 07:48:58 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uCZWJ-00030X-T9 for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 May 2025 07:48:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=e6huWnhgxFQ8bjGzWKZybwdE+ZlNVdAP3gw/ZnaEVN8=; b=VeNnnIb4yY7ZxzvY1v4AMGrVxL JYUd+lpi0PCZyj0V1zcCpm2c/47c8r6Iuh+hYiICmistjmmiAbDfKxbnLEpu6DMaeuclsXiZZ7U+g SBtzqZ/reiKT+iQCuX/PYHsfJ14zaftMMdvbXMxYo3vrXRHV43KpWmIR7DnhcOLDBtSQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=e6huWnhgxFQ8bjGzWKZybwdE+ZlNVdAP3gw/ZnaEVN8=; b=KoeTeYZtH0nPbCiDWYIQMQeLaw chamvq3WYIcmngD8jYNHQJk1PtA3xAP1DOjTv2eexpLb/maPI4h+bcIavPYpQBnS6Ik5ssRJJB7YE BCoemDqDjPbp9nYBZwM5rt2O/gih32/O2ETxN+U2KdzfDXTtD23LGOJQtlmUC7wZFhhk=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uCZW4-0003tA-3m for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 May 2025 07:48:47 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E2F5268BFE; Wed, 7 May 2025 09:48:17 +0200 (CEST) Date: Wed, 7 May 2025 09:48:17 +0200 From: Christoph Hellwig To: Chao Yu Message-ID: <20250507074817.GA4516@lst.de> References: <20250505092613.3451524-1-hch@lst.de> <43d55ab4-c490-4f3d-8331-dc47f427d06d@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <43d55ab4-c490-4f3d-8331-dc47f427d06d@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1uCZW4-0003tA-3m Subject: Re: [f2fs-dev] cleanup AOP_WRITEPAGE_ACTIVATE use in f2fs X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, May 07, 2025 at 03:38:20PM +0800, Chao Yu wrote: > On 5/5/25 17:25, Christoph Hellwig wrote: > > Hi all, > > > > this almost entirely cleans up usage of AOP_WRITEPAGE_ACTIVATE in f2fs. > > > > f2fs_sync_node_pages can still return it in a way that is not handled > > by any caller and eventually is propagated to userspace. This does look > > like a bug and needs attention by someone who actually knows the code. > > Oh, I guess this is a bug, thanks for catching this. > > Anyway, let me fix this based on your patchset. I'll resend a fixed version later today, maybe wait for that. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 029521FF1D1 for ; Wed, 7 May 2025 07:48:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746604104; cv=none; b=ZZu6zbH5XOaTS1wac0DB9ZoEDXLNH1R0jgv/Kn/UcV/ryCCuPQ/ItUqcA+HVSeZGrso0VKGEjjK8bD62cRTkyfqE0Uel59Ex1CJKWXmXBOHnwHrxtHV2tq4JBWaGEK0yL/5mDmhWgCR9epjzpKSmFl1MnXm834e5EMIE6OPWWK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746604104; c=relaxed/simple; bh=IgEv4Eehk4n+l1e3vnYnwsLz5urxODEy8r5PARr2Ubk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DuS6InU2s3KD/iLV6UPKGPPf/IZN3OKkqWV5XEkzeO6JAeLtYBQcARWxBBVM4XstAx27LfpjCgkpmDTgAk5qmBZpB2fs9xwtBmbxEDvThHbegaL6fIDmji+YTvGvfJCTCdlsy2tG0IQzcL/mx6OF5XXG9EisDO69Tx6E034sTSE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id E2F5268BFE; Wed, 7 May 2025 09:48:17 +0200 (CEST) Date: Wed, 7 May 2025 09:48:17 +0200 From: Christoph Hellwig To: Chao Yu Cc: Christoph Hellwig , Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: cleanup AOP_WRITEPAGE_ACTIVATE use in f2fs Message-ID: <20250507074817.GA4516@lst.de> References: <20250505092613.3451524-1-hch@lst.de> <43d55ab4-c490-4f3d-8331-dc47f427d06d@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43d55ab4-c490-4f3d-8331-dc47f427d06d@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, May 07, 2025 at 03:38:20PM +0800, Chao Yu wrote: > On 5/5/25 17:25, Christoph Hellwig wrote: > > Hi all, > > > > this almost entirely cleans up usage of AOP_WRITEPAGE_ACTIVATE in f2fs. > > > > f2fs_sync_node_pages can still return it in a way that is not handled > > by any caller and eventually is propagated to userspace. This does look > > like a bug and needs attention by someone who actually knows the code. > > Oh, I guess this is a bug, thanks for catching this. > > Anyway, let me fix this based on your patchset. I'll resend a fixed version later today, maybe wait for that.