From: Stefano Brivio <sbrivio@redhat.com>
To: Florian Westphal <fw@strlen.de>
Cc: <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nf-next] selftests: netfilter: nft_concat_range.sh: add coverage for 4bit group representation
Date: Wed, 7 May 2025 10:52:06 +0200 [thread overview]
Message-ID: <20250507105206.04eecc5d@elisabeth> (raw)
In-Reply-To: <20250506130716.3266-1-fw@strlen.de>
On Tue, 6 May 2025 15:07:11 +0200
Florian Westphal <fw@strlen.de> wrote:
> Pipapo supports a more compact '4 bit group' format that is chosen when
> the memory needed for the default exceeds a threshold (2mb).
>
> Add coverage for those code paths, the existing tests use small sets that
> are handled by the default representation.
>
> This comes with a test script run-time increase, but I think its ok:
>
> normal: 2m35s -> 3m9s
> debug: 3m24s -> 5m29s (with KSFT_MACHINE_SLOW=yes).
>
> Cc: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Florian Westphal <fw@strlen.de>
I hope you didn't find further matching issues with this, but surely
the new tests are better than hoping...
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
next prev parent reply other threads:[~2025-05-07 8:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 13:07 [PATCH nf-next] selftests: netfilter: nft_concat_range.sh: add coverage for 4bit group representation Florian Westphal
2025-05-07 8:52 ` Stefano Brivio [this message]
2025-05-07 8:54 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507105206.04eecc5d@elisabeth \
--to=sbrivio@redhat.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.