From: Jakub Kicinski <kuba@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: <netdev@vger.kernel.org>,
netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH net-next] selftests: netfilter: fix conntrack stress test failures on debug kernels
Date: Wed, 7 May 2025 17:04:37 -0700 [thread overview]
Message-ID: <20250507170437.0ed28860@kernel.org> (raw)
In-Reply-To: <20250507075000.5819-1-fw@strlen.de>
On Wed, 7 May 2025 09:49:55 +0200 Florian Westphal wrote:
> Jakub reports test failures on debug kernel:
> FAIL: proc inconsistency after uniq filter for ...
>
> This is because entries are expiring while validation is happening.
>
> Increase the timeout of ctnetlink injected entries and the
> icmp (ping) timeout to 1h to avoid this.
>
> To reduce run-time, add less entries via ctnetlink when KSFT_MACHINE_SLOW
> is set.
>
> also log of a failed run had:
> PASS: dump in netns had same entry count (-C 0, -L 0, -p 0, /proc 0)
>
> ... i.e. all entries already expired: add a check and set failure if
> this happens.
>
> While at it, include a diff when there were duplicate entries and add
> netns name to error messages (it tells if icmp or ctnetlink failed).
>
> Fixes: d33f889fd80c ("selftests: netfilter: add conntrack stress test")
> Reported-by: Jakub Kicinski <kuba@kernel.org>
> Closes: https://lore.kernel.org/netdev/20250506061125.1a244d12@kernel.org/
> Signed-off-by: Florian Westphal <fw@strlen.de>
Great! Run 6 times since and 100% green. Thanks for the quick reaction.
next prev parent reply other threads:[~2025-05-08 0:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 7:49 [PATCH net-next] selftests: netfilter: fix conntrack stress test failures on debug kernels Florian Westphal
2025-05-08 0:04 ` Jakub Kicinski [this message]
2025-05-09 2:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507170437.0ed28860@kernel.org \
--to=kuba@kernel.org \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.