From: Jakub Kicinski <kuba@kernel.org>
To: Gur Stavi <gur.stavi@huawei.com>
Cc: Fan Gong <gongfan1@huawei.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>, <linux-doc@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Bjorn Helgaas <helgaas@kernel.org>, luosifu <luosifu@huawei.com>,
Xin Guo <guoxin09@huawei.com>,
Shen Chenyang <shenchenyang1@hisilicon.com>,
Zhou Shuai <zhoushuai28@huawei.com>, Wu Like <wulike1@huawei.com>,
Shi Jing <shijing34@huawei.com>,
Meny Yossefi <meny.yossefi@huawei.com>,
Lee Trager <lee@trager.us>, Michael Ellerman <mpe@ellerman.id.au>,
Suman Ghosh <sumang@marvell.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Joe Damato <jdamato@fastly.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH net-next v13 1/1] hinic3: module initialization and tx/rx logic
Date: Wed, 7 May 2025 19:59:20 -0700 [thread overview]
Message-ID: <20250507195920.5227ee66@kernel.org> (raw)
In-Reply-To: <c20c6e48ac105658204a20a6bfac8398da2e514b.1746519748.git.gur.stavi@huawei.com>
On Tue, 6 May 2025 11:35:28 +0300 Gur Stavi wrote:
> + page = page_pool_alloc_frag(page_pool, &page_offset, buf_len,
> + GFP_ATOMIC | __GFP_COMP);
No need for __GFP_COMP. page pool will add it if order > 0
> +static struct sk_buff *hinic3_fetch_rx_buffer(struct hinic3_rxq *rxq,
> + u32 pkt_len)
> +{
> + struct net_device *netdev = rxq->netdev;
> + struct sk_buff *skb;
> + u32 sge_num;
> +
> + skb = netdev_alloc_skb_ip_align(netdev, HINIC3_RX_HDR_SIZE);
Looks like this is only called from NAPI so you can use napi_alloc_skb()
it has an object cache so it is measurably faster
prev parent reply other threads:[~2025-05-08 2:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 8:35 [PATCH net-next v13 0/1] net: hinic3: Add a driver for Huawei 3rd gen NIC Gur Stavi
2025-05-06 8:35 ` [PATCH net-next v13 1/1] hinic3: module initialization and tx/rx logic Gur Stavi
2025-05-08 2:59 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507195920.5227ee66@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=christophe.jaillet@wanadoo.fr \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=gur.stavi@huawei.com \
--cc=helgaas@kernel.org \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=lee@trager.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=meny.yossefi@huawei.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shenchenyang1@hisilicon.com \
--cc=shijing34@huawei.com \
--cc=sumang@marvell.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.