From: Chris Morgan <macroalpha82@gmail.com>
To: linux-sunxi@lists.linux.dev
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
ryan@testtoast.com, macromorgan@hotmail.com,
p.zabel@pengutronix.de, tzimmermann@suse.de,
maarten.lankhorst@linux.intel.com, simona@ffwll.ch,
airlied@gmail.com, mripard@kernel.org, samuel@sholland.org,
jernej.skrabec@gmail.com, wens@csie.org, conor+dt@kernel.org,
krzk+dt@kernel.org, robh@kernel.org
Subject: [PATCH V9 11/24] drm: sun4i: de33: vi_scaler: add Display Engine 3.3 (DE33) support
Date: Wed, 7 May 2025 15:19:30 -0500 [thread overview]
Message-ID: <20250507201943.330111-12-macroalpha82@gmail.com> (raw)
In-Reply-To: <20250507201943.330111-1-macroalpha82@gmail.com>
From: Chris Morgan <macromorgan@hotmail.com>
The vi_scaler appears to be used in preference to the ui_scaler module
for hardware video scaling in the DE33.
Enable support for this scaler.
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Ryan Walklin <ryan@testtoast.com>
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 20 ++++++++++++++++----
drivers/gpu/drm/sun4i/sun8i_vi_scaler.c | 4 +++-
2 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c
index 7a21d32ff1e4..3eefdb710dee 100644
--- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c
@@ -94,12 +94,24 @@ static int sun8i_ui_layer_update_coord(struct sun8i_mixer *mixer, int channel,
hscale = state->src_w / state->crtc_w;
vscale = state->src_h / state->crtc_h;
- sun8i_ui_scaler_setup(mixer, channel, src_w, src_h, dst_w,
- dst_h, hscale, vscale, hphase, vphase);
- sun8i_ui_scaler_enable(mixer, channel, true);
+ if (mixer->cfg->de_type == sun8i_mixer_de33) {
+ sun8i_vi_scaler_setup(mixer, channel, src_w, src_h,
+ dst_w, dst_h, hscale, vscale,
+ hphase, vphase,
+ state->fb->format);
+ sun8i_vi_scaler_enable(mixer, channel, true);
+ } else {
+ sun8i_ui_scaler_setup(mixer, channel, src_w, src_h,
+ dst_w, dst_h, hscale, vscale,
+ hphase, vphase);
+ sun8i_ui_scaler_enable(mixer, channel, true);
+ }
} else {
DRM_DEBUG_DRIVER("HW scaling is not needed\n");
- sun8i_ui_scaler_enable(mixer, channel, false);
+ if (mixer->cfg->de_type == sun8i_mixer_de33)
+ sun8i_vi_scaler_enable(mixer, channel, false);
+ else
+ sun8i_ui_scaler_enable(mixer, channel, false);
}
/* Set base coordinates */
diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_scaler.c b/drivers/gpu/drm/sun4i/sun8i_vi_scaler.c
index ad87ab395803..6839fd5ab602 100644
--- a/drivers/gpu/drm/sun4i/sun8i_vi_scaler.c
+++ b/drivers/gpu/drm/sun4i/sun8i_vi_scaler.c
@@ -835,7 +835,9 @@ static const u32 bicubic4coefftab32[480] = {
static u32 sun8i_vi_scaler_base(struct sun8i_mixer *mixer, int channel)
{
- if (mixer->cfg->de_type == sun8i_mixer_de3)
+ if (mixer->cfg->de_type == sun8i_mixer_de33)
+ return sun8i_channel_base(mixer, channel) + 0x3000;
+ else if (mixer->cfg->de_type == sun8i_mixer_de3)
return DE3_VI_SCALER_UNIT_BASE +
DE3_VI_SCALER_UNIT_SIZE * channel;
else
--
2.43.0
next prev parent reply other threads:[~2025-05-07 20:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 20:19 [PATCH V9 00/24] drm: sun4i: add Display Engine 3.3 (DE33) support Chris Morgan
2025-05-07 20:19 ` [PATCH V9 01/24] dt-bindings: clock: sun50i-h616-ccu: Add LVDS reset Chris Morgan
2025-05-09 14:12 ` Andre Przywara
2025-05-07 20:19 ` [PATCH V9 02/24] clk: sunxi-ng: h616: Add LVDS reset for LCD TCON Chris Morgan
2025-05-09 14:14 ` Andre Przywara
2025-05-09 14:29 ` Chen-Yu Tsai
2025-05-09 16:31 ` Andre Przywara
2025-05-09 20:05 ` Chris Morgan
2025-05-07 20:19 ` [PATCH V9 03/24] drm: sun4i: de2/de3: add mixer version enum Chris Morgan
2025-05-07 20:19 ` [PATCH V9 04/24] drm: sun4i: de2/de3: refactor mixer initialisation Chris Morgan
2025-05-07 20:19 ` [PATCH V9 05/24] drm: sun4i: de2/de3: add generic blender register reference function Chris Morgan
2025-05-07 20:19 ` [PATCH V9 06/24] drm: sun4i: de2/de3: use generic register reference function for layer configuration Chris Morgan
2025-05-07 20:19 ` [PATCH V9 07/24] dt-bindings: allwinner: add H616 DE33 bus binding Chris Morgan
2025-05-07 20:19 ` [PATCH V9 08/24] dt-bindings: allwinner: add H616 DE33 clock binding Chris Morgan
2025-05-07 20:19 ` [PATCH V9 09/24] dt-bindings: allwinner: add H616 DE33 mixer binding Chris Morgan
2025-05-07 20:19 ` [PATCH V9 10/24] clk: sunxi-ng: ccu: add Display Engine 3.3 (DE33) support Chris Morgan
2025-05-07 20:19 ` Chris Morgan [this message]
2025-05-07 20:19 ` [PATCH V9 12/24] drm: sun4i: de33: mixer: " Chris Morgan
2025-05-07 20:19 ` [PATCH V9 13/24] drm: sun4i: de33: mixer: add mixer configuration for the H616 Chris Morgan
2025-05-07 20:19 ` [PATCH V9 14/24] dt-bindings: allwinner: Add TCON_TOP and TCON_LCD clock/reset defines Chris Morgan
2025-05-07 20:19 ` [PATCH V9 15/24] dt-bindings: display: sun4i: Add compatible strings for H616 DE Chris Morgan
2025-05-07 20:19 ` [PATCH V9 16/24] dt-bindings: display: sun4i: Add compatible strings for H616 TCON TOP Chris Morgan
2025-05-07 20:19 ` [PATCH V9 17/24] dt-bindings: sram: sunxi-sram: Add H616 SRAM C compatible Chris Morgan
2025-05-07 20:19 ` [PATCH V9 18/24] dt-bindings: display: Add R40 and H616 display engine compatibles Chris Morgan
2025-05-07 20:19 ` [PATCH V9 19/24] drm/sun4i: tcon: Add support for R40 LCD Chris Morgan
2025-05-07 20:19 ` [PATCH V9 20/24] arm64: dts: allwinner: h616: add display engine, bus and mixer nodes Chris Morgan
2025-05-07 20:19 ` [PATCH V9 21/24] arm64: dts: allwinner: h616: Add TCON nodes to H616 DTSI Chris Morgan
2025-05-07 20:19 ` [PATCH V9 22/24] arm64: dts: allwinner: h616: add LCD and LVDS pins Chris Morgan
2025-05-07 20:19 ` [PATCH V9 23/24] arm64: dts: allwinner: rg35xx: Add GPIO backlight control Chris Morgan
2025-05-09 14:32 ` Andre Przywara
2025-05-09 20:02 ` Chris Morgan
2025-05-07 20:19 ` [PATCH V9 24/24] arm64: dts: allwinner: rg35xx: Enable LCD output Chris Morgan
2025-05-07 21:13 ` [PATCH V9 00/24] drm: sun4i: add Display Engine 3.3 (DE33) support Rob Herring
2025-05-08 18:34 ` Corentin Labbe
2025-05-08 7:26 ` Krzysztof Kozlowski
2025-05-09 13:08 ` Chris Morgan
2025-05-10 2:01 ` (subset) " Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507201943.330111-12-macroalpha82@gmail.com \
--to=macroalpha82@gmail.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=macromorgan@hotmail.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=ryan@testtoast.com \
--cc=samuel@sholland.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.