From: Greg KH <gregkh@linuxfoundation.org>
To: Rujra Bhatt <braker.noob.kernel@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [FIRST-PATCH] staging : sm750fb : ddk750_mode.c fixed codespell issue.
Date: Wed, 7 May 2025 16:37:06 +0200 [thread overview]
Message-ID: <2025050737-lunchtime-quake-6128@gregkh> (raw)
In-Reply-To: <aBtuviJ2FhJXNg7r@brak3rDesk>
On Wed, May 07, 2025 at 08:01:26PM +0530, Rujra Bhatt wrote:
> instead of "parm" structure variable, used "param" to ease the readability.
>
> Signed-off-by: Rujra Bhatt <braker.noob.kernel@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_mode.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 3b25892af713..8f2708632c88 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -203,19 +203,19 @@ static void program_mode_registers(struct mode_parameter *mode_param,
> }
> }
>
> -int ddk750_set_mode_timing(struct mode_parameter *parm, enum clock_type clock)
> +int ddk750_set_mode_timing(struct mode_parameter *param, enum clock_type clock)
> {
> struct pll_value pll;
>
> pll.input_freq = DEFAULT_INPUT_CLOCK;
> pll.clock_type = clock;
>
> - sm750_calc_pll_value(parm->pixel_clock, &pll);
> + sm750_calc_pll_value(param->pixel_clock, &pll);
> if (sm750_get_chip_type() == SM750LE) {
> /* set graphic mode via IO method */
> outb_p(0x88, 0x3d4);
> outb_p(0x06, 0x3d5);
> }
> - program_mode_registers(parm, &pll);
> + program_mode_registers(param, &pll);
This change is really not needed at all, sorry. Adding one character
doesn't make it easier to understand in my opinion.
thanks,
greg k-h
prev parent reply other threads:[~2025-05-07 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 14:31 [FIRST-PATCH] staging : sm750fb : ddk750_mode.c fixed codespell issue Rujra Bhatt
2025-05-07 14:37 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025050737-lunchtime-quake-6128@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=braker.noob.kernel@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.