All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sumit Garg <sumit.garg@kernel.org>
To: u-boot-qcom@groups.io, u-boot@lists.denx.de
Cc: casey.connolly@linaro.org, neil.armstrong@linaro.org,
	trini@konsulko.com, Sumit Garg <sumit.garg@oss.qualcomm.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: [PATCH] qcom_defconfig: Enable AUTOBOOT_KEYED support
Date: Thu,  8 May 2025 16:02:38 +0530	[thread overview]
Message-ID: <20250508103238.230608-1-sumit.garg@kernel.org> (raw)

From: Sumit Garg <sumit.garg@oss.qualcomm.com>

When debug serial port isn't connected, it is at least reported on RB1
that autoboot gets interrupted. It is probably due to random characters
on the UART RX line when disconnected. Lets try to fix this inconsistent
behaviour via enabling AUTOBOOT_KEYED such that the autoboot gets
interrupted only when the <SPACE> key gets pressed.

Reported-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
---
 configs/qcom_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
index 36e2f45d22a..e3dac23f1d0 100644
--- a/configs/qcom_defconfig
+++ b/configs/qcom_defconfig
@@ -15,6 +15,9 @@ CONFIG_FIT_VERBOSE=y
 CONFIG_BOOTSTD_FULL=y
 # CONFIG_BOOTMETH_VBE is not set
 CONFIG_BOOTDELAY=1
+CONFIG_AUTOBOOT_KEYED=y
+CONFIG_AUTOBOOT_PROMPT="Hit <SPACE> key to stop autoboot in %2ds\n"
+CONFIG_AUTOBOOT_STOP_STR=" "
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_USE_PREBOOT=y
 CONFIG_SAVE_PREV_BL_INITRAMFS_START_ADDR=y
-- 
2.43.0


             reply	other threads:[~2025-05-08 10:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-08 10:32 Sumit Garg [this message]
2025-05-09 10:45 ` [PATCH] qcom_defconfig: Enable AUTOBOOT_KEYED support Casey Connolly
2025-05-09 14:54   ` Stephan Gerhold
2025-05-12  7:01     ` Sumit Garg
2025-05-13 15:54       ` Casey Connolly
2025-05-15 11:11         ` Sumit Garg
2025-05-22 16:21       ` Stephan Gerhold
2025-06-23 23:49 ` Casey Connolly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250508103238.230608-1-sumit.garg@kernel.org \
    --to=sumit.garg@kernel.org \
    --cc=casey.connolly@linaro.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=sumit.garg@oss.qualcomm.com \
    --cc=trini@konsulko.com \
    --cc=u-boot-qcom@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.