Re: [PATCH 5.15.y] btrfs: do not clean up repair bio if submit fails

[Sasha Levin <sashal@kernel.org>]

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: 8cbc3001a3264d998d6b6db3e23f935c158abd4d

WARNING: Author mismatch between patch and upstream commit:
Backport author: bin.lan.cn@windriver.com
Commit author: Josef Bacik<josef@toxicpanda.com>

Status in newer kernel trees:
6.14.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Present (exact SHA1)
6.1.y | Present (exact SHA1)

Note: The patch differs from the upstream commit:
---
1:  8cbc3001a3264 ! 1:  90c24cbc95555 btrfs: do not clean up repair bio if submit fails
    @@ Metadata
      ## Commit message ##
         btrfs: do not clean up repair bio if submit fails
     
    +    [ Upstream commit 8cbc3001a3264d998d6b6db3e23f935c158abd4d ]
    +
         The submit helper will always run bio_endio() on the bio if it fails to
         submit, so cleaning up the bio just leads to a variety of use-after-free
         and NULL pointer dereference bugs because we race with the endio
    @@ Commit message
         Reviewed-by: Boris Burkov <boris@bur.io>
         Signed-off-by: Josef Bacik <josef@toxicpanda.com>
         Signed-off-by: David Sterba <dsterba@suse.com>
    +    [Minor context change fixed.]
    +    Signed-off-by: Bin Lan <bin.lan.cn@windriver.com>
    +    Signed-off-by: He Zhe <zhe.he@windriver.com>
     
      ## fs/btrfs/extent_io.c ##
     @@ fs/btrfs/extent_io.c: int btrfs_repair_one_sector(struct inode *inode,
      	const int icsum = bio_offset >> fs_info->sectorsize_bits;
      	struct bio *repair_bio;
    - 	struct btrfs_bio *repair_bbio;
    + 	struct btrfs_io_bio *repair_io_bio;
     -	blk_status_t status;
      
      	btrfs_debug(fs_info,
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-5.15.y       |  Success    |  Success   |