From: kernel test robot <lkp@intel.com>
To: Christoph Hellwig <hch@lst.de>,
Chuck Lever <chuck.lever@oracle.com>,
Trond Myklebust <trondmy@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Anna Schumaker <anna@kernel.org>,
David Howells <dhowells@redhat.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
linux-nfs@vger.kernel.org,
kernel-tls-handshake <kernel-tls-handshake@lists.linux.dev>,
keyrings@vger.kernel.org
Subject: Re: [PATCH 1/2] NFS: support the kernel keyring for TLS
Date: Thu, 8 May 2025 16:07:55 +0800 [thread overview]
Message-ID: <202505081535.3PS62D63-lkp@intel.com> (raw)
In-Reply-To: <20250507080944.3947782-2-hch@lst.de>
Hi Christoph,
kernel test robot noticed the following build errors:
[auto build test ERROR on trondmy-nfs/linux-next]
[also build test ERROR on linus/master v6.15-rc5 next-20250507]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Christoph-Hellwig/nfs-create-a-kernel-keyring/20250507-171041
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
patch link: https://lore.kernel.org/r/20250507080944.3947782-2-hch%40lst.de
patch subject: [PATCH 1/2] NFS: support the kernel keyring for TLS
config: hexagon-defconfig (https://download.01.org/0day-ci/archive/20250508/202505081535.3PS62D63-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250508/202505081535.3PS62D63-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505081535.3PS62D63-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/nfs/fs_context.c:567:37: error: incomplete definition of type 'struct key'
567 | if (test_bit(KEY_FLAG_REVOKED, &key->flags) ||
| ~~~^
include/linux/bitops.h:61:50: note: expanded from macro 'test_bit'
61 | #define test_bit(nr, addr) bitop(_test_bit, nr, addr)
| ^~~~
include/linux/bitops.h:45:37: note: expanded from macro 'bitop'
45 | __builtin_constant_p((uintptr_t)(addr) != (uintptr_t)NULL) && \
| ^~~~
include/linux/key.h:33:8: note: forward declaration of 'struct key'
33 | struct key;
| ^
>> fs/nfs/fs_context.c:567:37: error: incomplete definition of type 'struct key'
567 | if (test_bit(KEY_FLAG_REVOKED, &key->flags) ||
| ~~~^
include/linux/bitops.h:61:50: note: expanded from macro 'test_bit'
61 | #define test_bit(nr, addr) bitop(_test_bit, nr, addr)
| ^~~~
include/linux/bitops.h:46:16: note: expanded from macro 'bitop'
46 | (uintptr_t)(addr) != (uintptr_t)NULL && \
| ^~~~
include/linux/key.h:33:8: note: forward declaration of 'struct key'
33 | struct key;
| ^
>> fs/nfs/fs_context.c:567:37: error: incomplete definition of type 'struct key'
567 | if (test_bit(KEY_FLAG_REVOKED, &key->flags) ||
| ~~~^
include/linux/bitops.h:61:50: note: expanded from macro 'test_bit'
61 | #define test_bit(nr, addr) bitop(_test_bit, nr, addr)
| ^~~~
include/linux/bitops.h:47:50: note: expanded from macro 'bitop'
47 | __builtin_constant_p(*(const unsigned long *)(addr))) ? \
| ^~~~
include/linux/key.h:33:8: note: forward declaration of 'struct key'
33 | struct key;
| ^
>> fs/nfs/fs_context.c:567:15: error: use of undeclared identifier 'KEY_FLAG_REVOKED'
567 | if (test_bit(KEY_FLAG_REVOKED, &key->flags) ||
| ^
>> fs/nfs/fs_context.c:567:37: error: incomplete definition of type 'struct key'
567 | if (test_bit(KEY_FLAG_REVOKED, &key->flags) ||
| ~~~^
include/linux/bitops.h:61:50: note: expanded from macro 'test_bit'
61 | #define test_bit(nr, addr) bitop(_test_bit, nr, addr)
| ^~~~
include/linux/bitops.h:48:17: note: expanded from macro 'bitop'
48 | const##op(nr, addr) : op(nr, addr))
| ^~~~
include/linux/key.h:33:8: note: forward declaration of 'struct key'
33 | struct key;
| ^
>> fs/nfs/fs_context.c:567:37: error: incomplete definition of type 'struct key'
567 | if (test_bit(KEY_FLAG_REVOKED, &key->flags) ||
| ~~~^
include/linux/bitops.h:61:50: note: expanded from macro 'test_bit'
61 | #define test_bit(nr, addr) bitop(_test_bit, nr, addr)
| ^~~~
include/linux/bitops.h:48:32: note: expanded from macro 'bitop'
48 | const##op(nr, addr) : op(nr, addr))
| ^~~~
include/linux/key.h:33:8: note: forward declaration of 'struct key'
33 | struct key;
| ^
>> fs/nfs/fs_context.c:567:15: error: use of undeclared identifier 'KEY_FLAG_REVOKED'
567 | if (test_bit(KEY_FLAG_REVOKED, &key->flags) ||
| ^
>> fs/nfs/fs_context.c:567:15: error: use of undeclared identifier 'KEY_FLAG_REVOKED'
fs/nfs/fs_context.c:568:41: error: incomplete definition of type 'struct key'
568 | test_bit(KEY_FLAG_INVALIDATED, &key->flags)) {
| ~~~^
include/linux/bitops.h:61:50: note: expanded from macro 'test_bit'
61 | #define test_bit(nr, addr) bitop(_test_bit, nr, addr)
| ^~~~
include/linux/bitops.h:45:37: note: expanded from macro 'bitop'
45 | __builtin_constant_p((uintptr_t)(addr) != (uintptr_t)NULL) && \
| ^~~~
include/linux/key.h:33:8: note: forward declaration of 'struct key'
33 | struct key;
| ^
fs/nfs/fs_context.c:568:41: error: incomplete definition of type 'struct key'
568 | test_bit(KEY_FLAG_INVALIDATED, &key->flags)) {
| ~~~^
include/linux/bitops.h:61:50: note: expanded from macro 'test_bit'
61 | #define test_bit(nr, addr) bitop(_test_bit, nr, addr)
| ^~~~
include/linux/bitops.h:46:16: note: expanded from macro 'bitop'
46 | (uintptr_t)(addr) != (uintptr_t)NULL && \
| ^~~~
include/linux/key.h:33:8: note: forward declaration of 'struct key'
33 | struct key;
| ^
fs/nfs/fs_context.c:568:41: error: incomplete definition of type 'struct key'
568 | test_bit(KEY_FLAG_INVALIDATED, &key->flags)) {
| ~~~^
include/linux/bitops.h:61:50: note: expanded from macro 'test_bit'
61 | #define test_bit(nr, addr) bitop(_test_bit, nr, addr)
| ^~~~
include/linux/bitops.h:47:50: note: expanded from macro 'bitop'
47 | __builtin_constant_p(*(const unsigned long *)(addr))) ? \
| ^~~~
include/linux/key.h:33:8: note: forward declaration of 'struct key'
33 | struct key;
| ^
>> fs/nfs/fs_context.c:568:15: error: use of undeclared identifier 'KEY_FLAG_INVALIDATED'
568 | test_bit(KEY_FLAG_INVALIDATED, &key->flags)) {
| ^
fs/nfs/fs_context.c:568:41: error: incomplete definition of type 'struct key'
568 | test_bit(KEY_FLAG_INVALIDATED, &key->flags)) {
| ~~~^
include/linux/bitops.h:61:50: note: expanded from macro 'test_bit'
61 | #define test_bit(nr, addr) bitop(_test_bit, nr, addr)
| ^~~~
include/linux/bitops.h:48:17: note: expanded from macro 'bitop'
48 | const##op(nr, addr) : op(nr, addr))
| ^~~~
include/linux/key.h:33:8: note: forward declaration of 'struct key'
33 | struct key;
| ^
fs/nfs/fs_context.c:568:41: error: incomplete definition of type 'struct key'
568 | test_bit(KEY_FLAG_INVALIDATED, &key->flags)) {
| ~~~^
include/linux/bitops.h:61:50: note: expanded from macro 'test_bit'
61 | #define test_bit(nr, addr) bitop(_test_bit, nr, addr)
| ^~~~
include/linux/bitops.h:48:32: note: expanded from macro 'bitop'
48 | const##op(nr, addr) : op(nr, addr))
| ^~~~
include/linux/key.h:33:8: note: forward declaration of 'struct key'
33 | struct key;
| ^
>> fs/nfs/fs_context.c:568:15: error: use of undeclared identifier 'KEY_FLAG_INVALIDATED'
568 | test_bit(KEY_FLAG_INVALIDATED, &key->flags)) {
| ^
>> fs/nfs/fs_context.c:568:15: error: use of undeclared identifier 'KEY_FLAG_INVALIDATED'
16 errors generated.
vim +567 fs/nfs/fs_context.c
557
558 static int nfs_tls_key_verify(key_serial_t key_id)
559 {
560 struct key *key = key_lookup(key_id);
561 int error = 0;
562
563 if (IS_ERR(key)) {
564 pr_err("key id %08x not found\n", key_id);
565 return PTR_ERR(key);
566 }
> 567 if (test_bit(KEY_FLAG_REVOKED, &key->flags) ||
> 568 test_bit(KEY_FLAG_INVALIDATED, &key->flags)) {
569 pr_err("key id %08x revoked\n", key_id);
570 error = -EKEYREVOKED;
571 }
572
573 key_put(key);
574 return error;
575 }
576
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-05-08 8:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 8:09 RFC: support keyrings for NFS TLS mounts Christoph Hellwig
2025-05-07 8:09 ` [PATCH 1/2] NFS: support the kernel keyring for TLS Christoph Hellwig
2025-05-07 14:48 ` Sagi Grimberg
2025-05-07 15:01 ` Chuck Lever
2025-05-08 8:07 ` kernel test robot [this message]
2025-05-07 8:09 ` [PATCH 2/2] nfs: create a kernel keyring Christoph Hellwig
2025-05-07 14:51 ` Sagi Grimberg
2025-05-08 9:42 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-05-15 11:50 support keyrings for NFS TLS mounts v2 Christoph Hellwig
2025-05-15 11:50 ` [PATCH 1/2] NFS: support the kernel keyring for TLS Christoph Hellwig
2025-05-15 12:51 ` Jarkko Sakkinen
2025-05-15 14:46 ` Hannes Reinecke
2025-05-16 5:17 ` Christoph Hellwig
2025-05-16 17:01 ` Jarkko Sakkinen
2025-05-16 11:47 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202505081535.3PS62D63-lkp@intel.com \
--to=lkp@intel.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=jarkko@kernel.org \
--cc=kernel-tls-handshake@lists.linux.dev \
--cc=keyrings@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.