All of lore.kernel.org
 help / color / mirror / Atom feed
From: cel@kernel.org
To: NeilBrown <neil@brown.name>, Jeff Layton <jlayton@kernel.org>,
	Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: <linux-nfs@vger.kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v2 0/6] Remove svc_rqst :: rq_vec
Date: Thu,  8 May 2025 13:37:34 -0400	[thread overview]
Message-ID: <20250508173740.5475-1-cel@kernel.org> (raw)

From: Chuck Lever <chuck.lever@oracle.com>

I expect this arrangement will not be permanent: the end-goal
might be folio queues rather than bio_vecs.

I intend to insert these into the series that expands the maximum
r/wsize, once this series is reviewed.

Testing has shown no correctness issues. There is a consistent and
measurable performance loss on NFSv4.1 with the write path changes.
I've mitigated it somewhat in this version of the series, but I
still do not understand why it happens (it also happened when the
series used svc_fill_write_vector()).

Chuck Lever (6):
  NFSD: Use rqstp->rq_bvec in nfsd_iter_read()
  SUNRPC: Export xdr_buf_to_bvec()
  NFSD: De-duplicate the svc_fill_write_vector() call sites
  NFSD: Use rqstp->rq_bvec in nfsd_iter_write()
  SUNRPC: Remove svc_fill_write_vector()
  SUNRPC: Remove svc_rqst :: rq_vec

 fs/nfsd/nfs3proc.c         |  5 +--
 fs/nfsd/nfs4proc.c         |  8 ++---
 fs/nfsd/nfsproc.c          |  9 ++----
 fs/nfsd/vfs.c              | 65 +++++++++++++++++++++++++++-----------
 fs/nfsd/vfs.h              | 10 +++---
 include/linux/sunrpc/svc.h |  3 --
 net/sunrpc/svc.c           | 46 ---------------------------
 net/sunrpc/xdr.c           |  1 +
 8 files changed, 59 insertions(+), 88 deletions(-)

-- 
2.49.0


             reply	other threads:[~2025-05-08 17:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-08 17:37 cel [this message]
2025-05-08 17:37 ` [PATCH v2 1/6] NFSD: Use rqstp->rq_bvec in nfsd_iter_read() cel
2025-05-08 17:37 ` [PATCH v2 2/6] SUNRPC: Export xdr_buf_to_bvec() cel
2025-05-08 17:37 ` [PATCH v2 3/6] NFSD: De-duplicate the svc_fill_write_vector() call sites cel
2025-05-08 17:37 ` [PATCH v2 4/6] NFSD: Use rqstp->rq_bvec in nfsd_iter_write() cel
2025-05-08 17:37 ` [PATCH v2 5/6] SUNRPC: Remove svc_fill_write_vector() cel
2025-05-08 17:37 ` [PATCH v2 6/6] SUNRPC: Remove svc_rqst :: rq_vec cel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250508173740.5475-1-cel@kernel.org \
    --to=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=dai.ngo@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.