From: Jakub Kicinski <kuba@kernel.org>
To: Jesper Dangaard Brouer <hawk@kernel.org>
Cc: Jon Kohler <jon@nutanix.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Zvi Effron <zeffron@riotgames.com>,
Stanislav Fomichev <stfomichev@gmail.com>,
Jason Wang <jasowang@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Simon Horman <horms@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH net-next v3] xdp: Add helpers for head length, headroom, and metadata length
Date: Thu, 8 May 2025 18:26:07 -0700 [thread overview]
Message-ID: <20250508182607.75993cf3@kernel.org> (raw)
In-Reply-To: <3fed59c6-e959-4863-b1c5-1927ef0d61df@kernel.org>
On Thu, 8 May 2025 18:59:54 +0200 Jesper Dangaard Brouer wrote:
> I do notice Jakub isn't a fan of the patch in general, but it seems
> quite popular given the other high profile kernel developers that acked
> in V3. I think it increase code readability for people that are less
> familiar with XDP code and meaning of the pointers (e.g. data_hard_start
> vs. data_end vs. data vs. data_meta). (We don't even have some ascii art
> showing these pointers).
Yup, ASCII art would be great, hopefully
DOC: Basic sk_buff geometry
can be an inspiration.
next prev parent reply other threads:[~2025-05-09 1:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 12:52 [PATCH net-next v3] xdp: Add helpers for head length, headroom, and metadata length Jon Kohler
2025-05-06 17:43 ` Stanislav Fomichev
2025-05-07 13:29 ` Willem de Bruijn
2025-05-07 16:35 ` Jesper Dangaard Brouer
2025-05-07 17:02 ` Zvi Effron
2025-05-07 17:08 ` Jesper Dangaard Brouer
2025-05-07 17:21 ` Willem de Bruijn
2025-05-07 17:47 ` Jon Kohler
2025-05-07 19:04 ` Jesper Dangaard Brouer
2025-05-07 19:57 ` Jon Kohler
2025-05-07 20:58 ` Jesper Dangaard Brouer
2025-05-08 0:18 ` Jakub Kicinski
2025-05-08 3:19 ` Jon Kohler
2025-05-09 1:28 ` Jakub Kicinski
2025-05-08 3:18 ` Jon Kohler
2025-05-08 16:59 ` Jesper Dangaard Brouer
2025-05-09 1:26 ` Jakub Kicinski [this message]
2025-05-07 16:18 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250508182607.75993cf3@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=jon@nutanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stfomichev@gmail.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=zeffron@riotgames.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.