From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Daniel Wagner <wagi@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Hannes Reinecke <hare@kernel.org>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nvme-pci: lock per namespace in nvme_poll_irqdisable
Date: Fri, 9 May 2025 05:33:18 +0200 [thread overview]
Message-ID: <20250509033318.GA27794@lst.de> (raw)
In-Reply-To: <aBz0iLWpLUQR4rtX@kbusch-mbp>
On Thu, May 08, 2025 at 12:14:32PM -0600, Keith Busch wrote:
> On Thu, May 08, 2025 at 04:57:06PM +0200, Daniel Wagner wrote:
> > From: Keith Busch <kbusch@kernel.org>
> >
> > We need to lock this queue for that condition because the timeout work
> > executes per-namespace.
> >
> > Reported-by: Hannes Reinecke <hare@kernel.org>
> > Closes: https://lore.kernel.org/all/20240902130728.1999-1-hare@kernel.org/
> > Fixes: a0fa9647a54e ("NVMe: add blk polling support")
> > Signed-off-by: Keith Busch <kbusch@kernel.org>
> > Signed-off-by: Daniel Wagner <wagi@kernel.org>
>
> Looks good to me
>
> Reviewed-by: Keith Busch <kbusch@kernel.org>
This is originally attributed to you, so this review is a bit odd..
next prev parent reply other threads:[~2025-05-09 4:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 14:57 [PATCH v2] nvme-pci: lock per namespace in nvme_poll_irqdisable Daniel Wagner
2025-05-08 18:14 ` Keith Busch
2025-05-09 3:33 ` Christoph Hellwig [this message]
2025-05-09 4:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250509033318.GA27794@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=wagi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.