From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
Jiri Pirko <jiri@nvidia.com>, Gal Pressman <gal@nvidia.com>,
"Leon Romanovsky" <leonro@nvidia.com>,
Donald Hunter <donald.hunter@gmail.com>,
"Jiri Pirko" <jiri@resnulli.us>, Jonathan Corbet <corbet@lwn.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, Moshe Shemesh <moshe@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>,
Carolina Jubran <cjubran@nvidia.com>,
Cosmin Ratiu <cratiu@nvidia.com>
Subject: Re: [PATCH net-next V9 1/5] devlink: Extend devlink rate API with traffic classes bandwidth management
Date: Fri, 9 May 2025 08:16:25 -0700 [thread overview]
Message-ID: <20250509081625.5d4589a5@kernel.org> (raw)
In-Reply-To: <1746769389-463484-2-git-send-email-tariqt@nvidia.com>
On Fri, 9 May 2025 08:43:05 +0300 Tariq Toukan wrote:
> + -
> + name: devlink-rate-tc-index-max
> + header: uapi/linux/devlink.h
> + type: const
> + value: 7
Ugh, still wrong, the user space headers don't have uAPI in the path
when installed. They go to /usr/include/linux/$name.h
But for defines "local" to the family you don't have to specify header:
at all, just drop it.
And please do build tests the next version:
make -C tools/net/ynl/ W=1 -j
I'm going to also give you a hint that my next complaint will be that
there are no selftests in this series, and it extends uAPI.
--
pw-bot: cr
next prev parent reply other threads:[~2025-05-09 15:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 5:43 [PATCH net-next V9 0/5] Support rate management on traffic classes in devlink and mlx5 Tariq Toukan
2025-05-09 5:43 ` [PATCH net-next V9 1/5] devlink: Extend devlink rate API with traffic classes bandwidth management Tariq Toukan
2025-05-09 15:16 ` Jakub Kicinski [this message]
2025-05-11 6:43 ` Carolina Jubran
2025-05-12 14:27 ` Tariq Toukan
2025-05-14 7:38 ` Gal Pressman
2025-05-09 5:43 ` [PATCH net-next V9 2/5] net/mlx5: Add no-op implementation for setting tc-bw on rate objects Tariq Toukan
2025-05-09 5:43 ` [PATCH net-next V9 3/5] net/mlx5: Add support for setting tc-bw on nodes Tariq Toukan
2025-05-09 5:43 ` [PATCH net-next V9 4/5] net/mlx5: Add traffic class scheduling support for vport QoS Tariq Toukan
2025-05-09 5:43 ` [PATCH net-next V9 5/5] net/mlx5: Manage TC arbiter nodes and implement full support for tc-bw Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250509081625.5d4589a5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=corbet@lwn.net \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.