From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] mmap_24-1: Change vm.max_map_count if needed
Date: Fri, 9 May 2025 12:52:59 +0200 [thread overview]
Message-ID: <20250509105259.GA238712@pevik> (raw)
In-Reply-To: <415deb45-88d0-4717-b062-925c394169b9@suse.cz>
> On 07. 05. 25 19:53, Petr Vorel wrote:
> > Hi Martin,
> > > If vm.max_map_count system parameter is too high, mmap24-1 may get
> > > killed by OOM. Set the parameter to a reasonable low value so that
> > > mmap() quickly fails as expected.
> > LGTM.
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > The only thing which bothers me is that writing /proc/sys/vm/max_map_count
> > requires root. But I'm not sure if it's worth to add more code to check UID 0.
> We don't need a check, the test will simply fail to open the file and move
> on to the main test case. But I'll add an info message if that happens.
Testing without root with too high /proc/sys/vm/max_map_count will fail due not
able to lower down it. But sure, explaining message is IMHO good enough, thanks!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-05-09 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 15:45 [LTP] [PATCH] mmap_24-1: Change vm.max_map_count if needed Martin Doucha
2025-05-07 17:53 ` Petr Vorel
2025-05-09 4:03 ` Li Wang via ltp
2025-05-09 11:34 ` Martin Doucha
2025-05-09 12:00 ` Li Wang via ltp
2025-05-09 10:15 ` Martin Doucha
2025-05-09 10:52 ` Petr Vorel [this message]
2025-05-09 9:58 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250509105259.GA238712@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.