All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [axboe-block:for-6.16/block 49/106] block/blk-mq-sched.c:444 blk_mq_sched_reg_debugfs() warn: iterator 'i' not incremented
Date: Fri, 9 May 2025 13:08:05 +0800	[thread overview]
Message-ID: <202505091356.PvNPIRRx-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Ming Lei <ming.lei@redhat.com>
CC: Jens Axboe <axboe@kernel.dk>
CC: Yu Kuai <yukuai3@huawei.com>
CC: Nilay Shroff <nilay@linux.ibm.com>
CC: Christoph Hellwig <hch@lst.de>
CC: Hannes Reinecke <hare@suse.de>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-6.16/block
head:   824afb9b04648ea11531fc9047923ec07e7a943d
commit: ed3896acdcf038888a80a02dd264099e35f76b47 [49/106] block: add two helpers for registering/un-registering sched debugfs
:::::: branch date: 14 hours ago
:::::: commit date: 3 days ago
config: i386-randconfig-141-20250508 (https://download.01.org/0day-ci/archive/20250509/202505091356.PvNPIRRx-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202505091356.PvNPIRRx-lkp@intel.com/

New smatch warnings:
block/blk-mq-sched.c:444 blk_mq_sched_reg_debugfs() warn: iterator 'i' not incremented
block/blk-mq-sched.c:455 blk_mq_sched_unreg_debugfs() warn: iterator 'i' not incremented

Old smatch warnings:
block/blk-mq-sched.c:406 blk_mq_sched_tags_teardown() warn: iterator 'i' not incremented
block/blk-mq-sched.c:494 blk_mq_init_sched() warn: iterator 'i' not incremented
block/blk-mq-sched.c:533 blk_mq_sched_free_rqs() warn: iterator 'i' not incremented
block/blk-mq-sched.c:550 blk_mq_exit_sched() warn: iterator 'i' not incremented

vim +/i +444 block/blk-mq-sched.c

d97e594c51660b John Garry 2021-05-13  436  
ed3896acdcf038 Ming Lei   2025-05-05  437  static void blk_mq_sched_reg_debugfs(struct request_queue *q)
ed3896acdcf038 Ming Lei   2025-05-05  438  {
ed3896acdcf038 Ming Lei   2025-05-05  439  	struct blk_mq_hw_ctx *hctx;
ed3896acdcf038 Ming Lei   2025-05-05  440  	unsigned long i;
ed3896acdcf038 Ming Lei   2025-05-05  441  
ed3896acdcf038 Ming Lei   2025-05-05  442  	mutex_lock(&q->debugfs_mutex);
ed3896acdcf038 Ming Lei   2025-05-05  443  	blk_mq_debugfs_register_sched(q);
ed3896acdcf038 Ming Lei   2025-05-05 @444  	queue_for_each_hw_ctx(q, hctx, i)
ed3896acdcf038 Ming Lei   2025-05-05  445  		blk_mq_debugfs_register_sched_hctx(q, hctx);
ed3896acdcf038 Ming Lei   2025-05-05  446  	mutex_unlock(&q->debugfs_mutex);
ed3896acdcf038 Ming Lei   2025-05-05  447  }
ed3896acdcf038 Ming Lei   2025-05-05  448  
ed3896acdcf038 Ming Lei   2025-05-05  449  static void blk_mq_sched_unreg_debugfs(struct request_queue *q)
ed3896acdcf038 Ming Lei   2025-05-05  450  {
ed3896acdcf038 Ming Lei   2025-05-05  451  	struct blk_mq_hw_ctx *hctx;
ed3896acdcf038 Ming Lei   2025-05-05  452  	unsigned long i;
ed3896acdcf038 Ming Lei   2025-05-05  453  
ed3896acdcf038 Ming Lei   2025-05-05  454  	mutex_lock(&q->debugfs_mutex);
ed3896acdcf038 Ming Lei   2025-05-05 @455  	queue_for_each_hw_ctx(q, hctx, i)
ed3896acdcf038 Ming Lei   2025-05-05  456  		blk_mq_debugfs_unregister_sched_hctx(hctx);
ed3896acdcf038 Ming Lei   2025-05-05  457  	blk_mq_debugfs_unregister_sched(q);
ed3896acdcf038 Ming Lei   2025-05-05  458  	mutex_unlock(&q->debugfs_mutex);
ed3896acdcf038 Ming Lei   2025-05-05  459  }
ed3896acdcf038 Ming Lei   2025-05-05  460  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2025-05-09  5:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202505091356.PvNPIRRx-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.