Re: [RFC 19/19] mm, netmem: remove the page pool members in struct page

[kernel test robot <lkp@intel.com>]

Hi Byungchul,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on fd93b3350b4314eebd8fbf0fea3ca7fe48d777e3]

url:    https://github.com/intel-lab-lkp/linux/commits/Byungchul-Park/netmem-rename-struct-net_iov-to-struct-netmem_desc/20250509-195458
base:   fd93b3350b4314eebd8fbf0fea3ca7fe48d777e3
patch link:    https://lore.kernel.org/r/20250509115126.63190-20-byungchul%40sk.com
patch subject: [RFC 19/19] mm, netmem: remove the page pool members in struct page
config: x86_64-buildonly-randconfig-003-20250510 (https://download.01.org/0day-ci/archive/20250510/202505100932.uzAMBW1y-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250510/202505100932.uzAMBW1y-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505100932.uzAMBW1y-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/netdevsim/netdev.c: In function 'nsim_pp_hold_write':
>> drivers/net/netdevsim/netdev.c:852:49: error: 'struct page' has no member named 'pp'
     852 |                 page_pool_put_full_page(ns->page->pp, ns->page, false);
         |                                                 ^~
   drivers/net/netdevsim/netdev.c: In function 'nsim_destroy':
   drivers/net/netdevsim/netdev.c:1077:49: error: 'struct page' has no member named 'pp'
    1077 |                 page_pool_put_full_page(ns->page->pp, ns->page, false);
         |                                                 ^~


vim +852 drivers/net/netdevsim/netdev.c

1580cbcbfe770b Jakub Kicinski 2024-04-12  827  
1580cbcbfe770b Jakub Kicinski 2024-04-12  828  static ssize_t
1580cbcbfe770b Jakub Kicinski 2024-04-12  829  nsim_pp_hold_write(struct file *file, const char __user *data,
1580cbcbfe770b Jakub Kicinski 2024-04-12  830  		   size_t count, loff_t *ppos)
1580cbcbfe770b Jakub Kicinski 2024-04-12  831  {
1580cbcbfe770b Jakub Kicinski 2024-04-12  832  	struct netdevsim *ns = file->private_data;
1580cbcbfe770b Jakub Kicinski 2024-04-12  833  	ssize_t ret;
1580cbcbfe770b Jakub Kicinski 2024-04-12  834  	bool val;
1580cbcbfe770b Jakub Kicinski 2024-04-12  835  
1580cbcbfe770b Jakub Kicinski 2024-04-12  836  	ret = kstrtobool_from_user(data, count, &val);
1580cbcbfe770b Jakub Kicinski 2024-04-12  837  	if (ret)
1580cbcbfe770b Jakub Kicinski 2024-04-12  838  		return ret;
1580cbcbfe770b Jakub Kicinski 2024-04-12  839  
1580cbcbfe770b Jakub Kicinski 2024-04-12  840  	rtnl_lock();
1580cbcbfe770b Jakub Kicinski 2024-04-12  841  	ret = count;
1580cbcbfe770b Jakub Kicinski 2024-04-12  842  	if (val == !!ns->page)
1580cbcbfe770b Jakub Kicinski 2024-04-12  843  		goto exit;
1580cbcbfe770b Jakub Kicinski 2024-04-12  844  
1580cbcbfe770b Jakub Kicinski 2024-04-12  845  	if (!netif_running(ns->netdev) && val) {
1580cbcbfe770b Jakub Kicinski 2024-04-12  846  		ret = -ENETDOWN;
1580cbcbfe770b Jakub Kicinski 2024-04-12  847  	} else if (val) {
915c82f842f955 Jakub Kicinski 2025-01-07  848  		ns->page = page_pool_dev_alloc_pages(ns->rq[0]->page_pool);
1580cbcbfe770b Jakub Kicinski 2024-04-12  849  		if (!ns->page)
1580cbcbfe770b Jakub Kicinski 2024-04-12  850  			ret = -ENOMEM;
1580cbcbfe770b Jakub Kicinski 2024-04-12  851  	} else {
1580cbcbfe770b Jakub Kicinski 2024-04-12 @852  		page_pool_put_full_page(ns->page->pp, ns->page, false);
1580cbcbfe770b Jakub Kicinski 2024-04-12  853  		ns->page = NULL;
1580cbcbfe770b Jakub Kicinski 2024-04-12  854  	}
1580cbcbfe770b Jakub Kicinski 2024-04-12  855  
1580cbcbfe770b Jakub Kicinski 2024-04-12  856  exit:
b9b8301d369b4c Eric Dumazet   2024-12-16  857  	rtnl_unlock();
b9b8301d369b4c Eric Dumazet   2024-12-16  858  	return ret;
1580cbcbfe770b Jakub Kicinski 2024-04-12  859  }
1580cbcbfe770b Jakub Kicinski 2024-04-12  860  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki