Re: [PATCH v4] pwm: tidyup PWM menu for Renesas

["Niklas Söderlund" <niklas.soderlund@ragnatech.se>]

On 2025-05-12 10:09:17 +0200, "Uwe Kleine-König" wrote:
> On Mon, May 12, 2025 at 09:39:49AM +0200, Niklas Söderlund wrote:
> > Hi Morimoto-san,
> > 
> > I like cleanup patches!
> > 
> > On 2025-05-12 06:33:12 +0000, Kuninori Morimoto wrote:
> > > Because current PWM Kconfig is sorting by symbol name,
> > > it looks strange ordering in menuconfig.
> > > 
> > > =>	[ ]   Renesas R-Car PWM support
> > > =>	[ ]   Renesas TPU PWM support
> > > 	[ ]   Rockchip PWM support
> > > =>	[ ]   Renesas RZ/G2L General PWM Timer support
> > > =>	[ ]   Renesas RZ/G2L MTU3a PWM Timer support
> > > 
> > > Let's use common CONFIG_PWM_RENESAS_xxx symbol name for Renesas,
> > > and sort it.
> > 
> > I think you also need to update the symbol names in the various config 
> > files found in tree. A quick look,
> > 
> >     $ git grep CONFIG_PWM_RCAR -- arch
> >     arch/arm/configs/multi_v7_defconfig:1206:CONFIG_PWM_RCAR=m
> >     arch/arm/configs/shmobile_defconfig:220:CONFIG_PWM_RCAR=y
> >     arch/arm64/configs/defconfig:1553:CONFIG_PWM_RCAR=m
> > 
> >     $ git grep CONFIG_PWM_RZG2L_GPT -- arch
> >     arch/arm64/configs/defconfig:1534:CONFIG_PWM_RZG2L_GPT=m
> > 
> >     $ git grep CONFIG_PWM_RZ_MTU3 -- arch
> >     arch/arm64/configs/defconfig:1556:CONFIG_PWM_RZ_MTU3=m
> > 
> > > 
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> > > v3 -> v4
> > > 	- Based on linux-next/master
> > > 
> > >  arch/arm/configs/multi_v7_defconfig |  2 +-
> > >  arch/arm/configs/shmobile_defconfig |  2 +-
> > >  arch/arm64/configs/defconfig        |  6 ++--
> 
> I didn't check in detail, but looking at the diffstat I'd claim that
> adapting the defconfigs is coped for?

You are correct, my bad. Had the wrong branch when testing. Sorry for the 
noise.

> 
> Best regards
> Uwe



-- 
Kind Regards,
Niklas Söderlund