From: Simon Horman <horms@kernel.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
anton.reding@landisgyr.com
Subject: Re: [PATCH net v2] net: cadence: macb: Fix a possible deadlock in macb_halt_tx.
Date: Mon, 12 May 2025 12:15:06 +0100 [thread overview]
Message-ID: <20250512111506.GA3339421@horms.kernel.org> (raw)
In-Reply-To: <20250509121935.16282-1-othacehe@gnu.org>
On Fri, May 09, 2025 at 02:19:35PM +0200, Mathieu Othacehe wrote:
> There is a situation where after THALT is set high, TGO stays high as
> well. Because jiffies are never updated, as we are in a context with
> interrupts disabled, we never exit that loop and have a deadlock.
>
> That deadlock was noticed on a sama5d4 device that stayed locked for days.
>
> Use retries instead of jiffies so that the timeout really works and we do
> not have a deadlock anymore.
>
> Fixes: e86cd53afc590 ("net/macb: better manage tx errors")
>
> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
> ---
> v2: Use read_poll_timeout_atomic and add a Fixes tag.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-05-12 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 12:19 [PATCH net v2] net: cadence: macb: Fix a possible deadlock in macb_halt_tx Mathieu Othacehe
2025-05-12 11:15 ` Simon Horman [this message]
2025-05-13 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512111506.GA3339421@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anton.reding@landisgyr.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=othacehe@gnu.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.