All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Olivier Benjamin <olivier.benjamin@bootlin.com>
Cc: buildroot@buildroot.org, Phil Eichinger <phil.eichinger@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/psplash: add support for fullscreen config option
Date: Mon, 12 May 2025 14:07:32 +0200	[thread overview]
Message-ID: <20250512140732.6f179e4a@windsurf> (raw)
In-Reply-To: <20250507114042.96291-1-olivier.benjamin@bootlin.com>

Hello,

On Wed,  7 May 2025 13:40:41 +0200
Olivier Benjamin <olivier.benjamin@bootlin.com> wrote:

> diff --git a/package/psplash/Config.in b/package/psplash/Config.in
> index 61162fa583..ca39cd0ee3 100644
> --- a/package/psplash/Config.in
> +++ b/package/psplash/Config.in
> @@ -47,6 +47,12 @@ config BR2_PACKAGE_PSPLASH_STARTUP_MSG
>  	help
>  	  Enable text banner output on startup.
>  
> +config BR2_PACKAGE_PSPLASH_FULL_SCREEN
> +	bool "use fullscreen mode"
> +	default n

"default n" is useless, as it's... the default.

> diff --git a/package/psplash/psplash.mk b/package/psplash/psplash.mk
> index 62268e778b..bb249e7de8 100644
> --- a/package/psplash/psplash.mk
> +++ b/package/psplash/psplash.mk
> @@ -31,6 +31,12 @@ else
>  PSPLASH_CONF_OPTS += --disable-startup-msg
>  endif
>  
> +ifeq ($(BR2_PACKAGE_PSPLASH_FULL_SCREEN),y)
> +PSPLASH_CONF_OPTS += --enable-img-fullscreen
> +else
> +PSPLASH_CONF_OPTS += --disable-img-fullscreen
> +endif

The explicit --enable-<foo> is apparently causing problems, due to bugs
in the upstream configure.ac:

  https://gitlab.com/buildroot.org/buildroot/-/issues/112

Could you have a look?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2025-05-12 12:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-07 11:40 [Buildroot] [PATCH 1/1] package/psplash: add support for fullscreen config option Olivier Benjamin via buildroot
2025-05-09 13:27 ` Julien Olivain
2025-05-09 17:33   ` Olivier Benjamin via buildroot
2025-05-12 12:07 ` Thomas Petazzoni via buildroot [this message]
2025-05-12 13:04   ` Olivier Benjamin via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250512140732.6f179e4a@windsurf \
    --to=buildroot@buildroot.org \
    --cc=olivier.benjamin@bootlin.com \
    --cc=phil.eichinger@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.