From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
aalbersh@kernel.org, hans.holmberg@wdc.com,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs_mdrestore: don't allow restoring onto zoned block devices
Date: Mon, 12 May 2025 17:25:25 +0200 [thread overview]
Message-ID: <20250512152525.GA9425@lst.de> (raw)
In-Reply-To: <20250512151240.GE2701446@frogsfrogsfrogs>
On Mon, May 12, 2025 at 08:12:40AM -0700, Darrick J. Wong wrote:
> I wonder if there ought to be guards around blkzoned.h, but OTOH that
> seems to have been introduced in 4.9 around 8 years ago so maybe it's
> fine?
I think we're fine. If not we'll also need to do this for mkfs and
repair anyway.
> /me is willing to go along with that if the maintainer is. Meanwhile
> the code changes make sense so as long as there isn't some "set the
> write pointer to an arbitrary LBA" command that I missed,
There isn't. It would have been really useful for testing, though..
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
>
> since we wouldn't be mdrestoring user file data to the zoned section,
> right?
Well, mdrestore can't even restore user data :)
next prev parent reply other threads:[~2025-05-12 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 13:17 [PATCH] xfs_mdrestore: don't allow restoring onto zoned block devices Christoph Hellwig
2025-05-12 15:12 ` Darrick J. Wong
2025-05-12 15:25 ` Christoph Hellwig [this message]
2025-05-13 10:01 ` Andrey Albershteyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512152525.GA9425@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.