From: Jakub Kicinski <kuba@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Donald Hunter <donald.hunter@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jason Xing <kernelxing@tencent.com>,
Richard Cochran <richardcochran@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
"Russell King (Oracle)" <linux@armlinux.org.uk>
Subject: Re: [PATCH net-next v2] net: Add support for providing the PTP hardware source in tsinfo
Date: Mon, 12 May 2025 16:57:49 -0700 [thread overview]
Message-ID: <20250512165749.375bcbbd@kernel.org> (raw)
In-Reply-To: <20250512101942.4a5b80a1@kmaincent-XPS-13-7390>
On Mon, 12 May 2025 10:19:42 +0200 Kory Maincent wrote:
> > - name: ts-hwtstamp-source
> > - enum-name: hwtstamp-source
> > - header: linux/ethtool.h
> > + name: hwtstamp-source
> > + name-prefix: hwtstamp-source-
> > type: enum
> > - name-prefix: hwtstamp-source
>
> Should we keep the enum-name property as is is already use, or do you prefer to
> rename all its use to ethtool-hwtstamp-source?
Looks like we already have a number of such cases - attribute name
and enum name are the same. I'd keep them the same, I don't think
there's much room for confusion either in C or Python.
prev parent reply other threads:[~2025-05-12 23:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 12:18 [PATCH net-next v2] net: Add support for providing the PTP hardware source in tsinfo Kory Maincent
2025-05-09 2:36 ` Jakub Kicinski
2025-05-12 8:19 ` Kory Maincent
2025-05-12 23:57 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512165749.375bcbbd@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernelxing@tencent.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.