Re: [net-next PATCH 4/4] octeontx2: Add new tracepoint otx2_msg_status

[Simon Horman <horms@kernel.org>]

On Mon, May 12, 2025 at 02:11:55PM +0530, Subbaraya Sundeep wrote:
> Apart from netdev interface Octeontx2 PF does the following:
> 1. Sends its own requests to AF and receives responses from AF.
> 2. Receives async messages from AF.
> 3. Forwards VF requests to AF, sends respective responses from AF to VFs.
> 4. Sends async messages to VFs.
> This patch adds new tracepoint otx2_msg_status to display the status
> of PF wrt mailbox handling.
> 
> Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> ---
>  drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c |  1 +
>  drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.h | 15 +++++++++++++++
>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c  | 18 ++++++++++++++++++
>  3 files changed, 34 insertions(+)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c
> index 775fd4c..5f69380 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c
> @@ -11,3 +11,4 @@
>  EXPORT_TRACEPOINT_SYMBOL(otx2_msg_alloc);
>  EXPORT_TRACEPOINT_SYMBOL(otx2_msg_interrupt);
>  EXPORT_TRACEPOINT_SYMBOL(otx2_msg_process);
> +EXPORT_TRACEPOINT_SYMBOL(otx2_msg_status);
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.h b/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.h
> index 721d4a5..e7c2160 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.h
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.h
> @@ -118,6 +118,21 @@ TRACE_EVENT(otx2_msg_wait_rsp,
>  		      __get_str(dev))
>  );
>  
> +TRACE_EVENT(otx2_msg_status,
> +	    TP_PROTO(const struct pci_dev *pdev, const char *msg, u16 num_msgs),
> +	    TP_ARGS(pdev, msg, num_msgs),
> +	    TP_STRUCT__entry(__string(dev, pci_name(pdev))
> +			     __string(str, msg)
> +			     __field(u16, num_msgs)
> +	    ),
> +	    TP_fast_assign(__assign_str(dev, pci_name(pdev))
> +			   __assign_str(str, msg)

In order to compile against net-next __assign_str() should
only be passed one argument. Likewise elsewhere in this series.

And, also in order to compile against net-next there needs
to be a ';' after each __assign_str(..).

> +			   __entry->num_msgs = num_msgs;
> +	    ),
> +	    TP_printk("[%s] %s num_msgs:%d\n", __get_str(dev),
> +		      __get_str(str), __entry->num_msgs)
> +);
> +
>  #endif /* __RVU_TRACE_H */
>  
>  #undef TRACE_INCLUDE_PATH

...

-- 
pw-bot: changes-requested