Re: [RFC v2 4/4] vduse-blk: Add VIRTIO_BLK_T_OUT_FUA command support

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]

On Thu, May 08, 2025 at 05:20:44PM +0100, Alberto Faria wrote:

If you respin, please add something to the commit description explaining
that an earlier commit already updated
block/export/virtio-blk-handler.c:virtio_blk_process_req() to handle FUA
requests.

> Signed-off-by: Alberto Faria <afaria@redhat.com>
> ---
>  block/export/vduse-blk.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/block/export/vduse-blk.c b/block/export/vduse-blk.c
> index bd852e538dc..36c3c0a56e6 100644
> --- a/block/export/vduse-blk.c
> +++ b/block/export/vduse-blk.c
> @@ -329,7 +329,8 @@ static int vduse_blk_exp_create(BlockExport *exp, BlockExportOptions *opts,
>                 (1ULL << VIRTIO_BLK_F_BLK_SIZE) |
>                 (1ULL << VIRTIO_BLK_F_FLUSH) |
>                 (1ULL << VIRTIO_BLK_F_DISCARD) |
> -               (1ULL << VIRTIO_BLK_F_WRITE_ZEROES);
> +               (1ULL << VIRTIO_BLK_F_WRITE_ZEROES) |
> +               (1ULL << VIRTIO_BLK_F_OUT_FUA);
>  
>      if (num_queues > 1) {
>          features |= 1ULL << VIRTIO_BLK_F_MQ;
> -- 
> 2.49.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]