From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Damien Le Moal <dlemoal@kernel.org>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH] block: Split bios in LBA order
Date: Tue, 13 May 2025 08:44:34 +0200 [thread overview]
Message-ID: <20250513064434.GA1199@lst.de> (raw)
In-Reply-To: <20250512225623.243507-1-bvanassche@acm.org>
On Mon, May 12, 2025 at 03:56:23PM -0700, Bart Van Assche wrote:
> The block layer submits bio fragments in opposite LBA order. Fix this as
> follows:
> - Introduce a new function bio_split_to_limits_and_submit() that has the
> same behavior as the existing bio_split_to_limits() function. This
> involves splitting a bio and submitting the fragment with the highest
> LBA by calling submit_bio_noacct().
> - Use the new function bio_split_to_limits_and_submit() in all drivers
> that are fine with submitting split bios in opposite LBA order.
If you have to rename a user visible symbol, please do that in a
preparation patch.
Also how do you determine some drivers are fine with one order while
others are not?
> - Modify blk_mq_submit_bio() and dm_split_and_process_bio() such that
> bio fragments are submitted in LBA order.
blk_mq_submit_bio calls __bio_split_to_limits, which returns the
bio split off the beginning of the passed in bio by bio_submit_split.
I don't see how that would reorder anything.
next prev parent reply other threads:[~2025-05-13 6:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 22:56 [PATCH] block: Split bios in LBA order Bart Van Assche
2025-05-13 6:44 ` Christoph Hellwig [this message]
2025-05-13 7:28 ` Yu Kuai
2025-05-13 20:36 ` Bart Van Assche
2025-05-14 5:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250513064434.GA1199@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.